Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[event v2] pause coin event migration #15945

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lightmark
Copy link
Contributor

Description

Too many external developers depend on coin v1 events including CEX. So the strategy is to keep coin event v1 and then after APT migration to FA, we can activate the coin v2 events here.

Copy link

trunk-io bot commented Feb 13, 2025

⏱️ 2h 9m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 47m 🟩🟩
check-dynamic-deps 16m 🟩🟩🟩🟩🟩 (+2 more)
rust-cargo-deny 13m 🟩🟩🟩🟩🟩 (+2 more)
rust-targeted-unit-tests 11m 🟥
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 9m 🟩🟩
rust-doc-tests 6m 🟩
rust-doc-tests 6m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
general-lints 3m 🟩🟩🟩🟩🟩 (+2 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 1m 🟩🟩🟩🟩🟩 (+2 more)
file_change_determinator 22s 🟩🟩
permission-check 20s 🟩🟩🟩🟩🟩 (+2 more)
permission-check 17s 🟩🟩🟩🟩🟩 (+2 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@lightmark lightmark requested review from igor-aptos and removed request for davidiw, wrwg and movekevin February 13, 2025 16:38
@lightmark lightmark force-pushed the lightmark/pause_coin_v2_events branch from 068c3d0 to 6ba8c8c Compare February 13, 2025 16:58
@lightmark lightmark force-pushed the lightmark/pause_coin_v2_events branch from 6ba8c8c to fd58cd3 Compare February 15, 2025 17:32
@lightmark lightmark force-pushed the lightmark/pause_coin_v2_events branch from fd58cd3 to da8cde0 Compare February 16, 2025 12:51
@lightmark lightmark force-pushed the lightmark/pause_coin_v2_events branch from da8cde0 to 28e88d4 Compare February 16, 2025 13:00
@lightmark lightmark enabled auto-merge (squash) February 17, 2025 17:59

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 822f04e116a3d468f268bd8ccf123bce49eab923

two traffics test: inner traffic : committed: 12533.30 txn/s, submitted: 12547.72 txn/s, expired: 14.41 txn/s, latency: 3092.61 ms, (p50: 3000 ms, p70: 3000, p90: 3600 ms, p99: 6000 ms), latency samples: 4765420
two traffics test : committed: 99.99 txn/s, latency: 1727.57 ms, (p50: 1700 ms, p70: 1700, p90: 2000 ms, p99: 3000 ms), latency samples: 1740
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.648, avg: 1.558", "ConsensusProposalToOrdered: max: 0.333, avg: 0.327", "ConsensusOrderedToCommit: max: 0.565, avg: 0.536", "ConsensusProposalToCommit: max: 0.893, avg: 0.862"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.02s no progress at version 31984 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.15s no progress at version 2304321 (avg 1.15s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on b5a1cd28bd43389cd205340cced6db63d6813f79 ==> 822f04e116a3d468f268bd8ccf123bce49eab923

Compatibility test results for b5a1cd28bd43389cd205340cced6db63d6813f79 ==> 822f04e116a3d468f268bd8ccf123bce49eab923 (PR)
1. Check liveness of validators at old version: b5a1cd28bd43389cd205340cced6db63d6813f79
compatibility::simple-validator-upgrade::liveness-check : committed: 12482.82 txn/s, latency: 2617.83 ms, (p50: 2700 ms, p70: 2800, p90: 3100 ms, p99: 4100 ms), latency samples: 411600
2. Upgrading first Validator to new version: 822f04e116a3d468f268bd8ccf123bce49eab923
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3399.24 txn/s, latency: 8710.34 ms, (p50: 9300 ms, p70: 10500, p90: 11400 ms, p99: 11600 ms), latency samples: 73780
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3460.88 txn/s, latency: 9956.74 ms, (p50: 10800 ms, p70: 11400, p90: 11400 ms, p99: 11500 ms), latency samples: 129400
3. Upgrading rest of first batch to new version: 822f04e116a3d468f268bd8ccf123bce49eab923
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 980.72 txn/s, submitted: 980.87 txn/s, expired: 0.14 txn/s, latency: 8786.67 ms, (p50: 9400 ms, p70: 10500, p90: 11200 ms, p99: 11400 ms), latency samples: 74869
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3385.34 txn/s, latency: 10173.73 ms, (p50: 11100 ms, p70: 11500, p90: 11500 ms, p99: 11800 ms), latency samples: 128220
4. upgrading second batch to new version: 822f04e116a3d468f268bd8ccf123bce49eab923
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6086.86 txn/s, latency: 5002.29 ms, (p50: 5800 ms, p70: 6200, p90: 6400 ms, p99: 6400 ms), latency samples: 114800
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6034.43 txn/s, latency: 5645.60 ms, (p50: 6200 ms, p70: 6300, p90: 6500 ms, p99: 6800 ms), latency samples: 205940
5. check swarm health
Compatibility test for b5a1cd28bd43389cd205340cced6db63d6813f79 ==> 822f04e116a3d468f268bd8ccf123bce49eab923 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b5a1cd28bd43389cd205340cced6db63d6813f79 ==> 822f04e116a3d468f268bd8ccf123bce49eab923

Compatibility test results for b5a1cd28bd43389cd205340cced6db63d6813f79 ==> 822f04e116a3d468f268bd8ccf123bce49eab923 (PR)
Upgrade the nodes to version: 822f04e116a3d468f268bd8ccf123bce49eab923
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1486.38 txn/s, submitted: 1492.31 txn/s, failed submission: 5.93 txn/s, expired: 5.93 txn/s, latency: 1885.93 ms, (p50: 1600 ms, p70: 2200, p90: 3000 ms, p99: 4500 ms), latency samples: 135400
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1614.51 txn/s, submitted: 1620.21 txn/s, failed submission: 5.70 txn/s, expired: 5.70 txn/s, latency: 1716.90 ms, (p50: 1500 ms, p70: 1900, p90: 2700 ms, p99: 4000 ms), latency samples: 147220
5. check swarm health
Compatibility test for b5a1cd28bd43389cd205340cced6db63d6813f79 ==> 822f04e116a3d468f268bd8ccf123bce49eab923 passed
Upgrade the remaining nodes to version: 822f04e116a3d468f268bd8ccf123bce49eab923
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1587.66 txn/s, submitted: 1595.92 txn/s, failed submission: 8.26 txn/s, expired: 8.26 txn/s, latency: 1768.70 ms, (p50: 1500 ms, p70: 1800, p90: 2700 ms, p99: 3900 ms), latency samples: 142182
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants