Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half the default max gas amount to 100000 #621

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Jan 24, 2025

Description

There have been many users that report insufficient funds for txns. Users report seemingly having enough APT, usually some amount like .15 APT. By default, you need to have minimum .2 APT to send any txn to cover the potential max gas charge. This is certainly too high for 99% of txns.

With this change, by default you need .1 APT.

We should consider half-ing this again to 50000 (or lower to 25000) to by default require .05 APT.

Test Plan

Related Links

Checklist

  • Have you ran pnpm fmt?
  • Have you updated the CHANGELOG.md?

@heliuchuan heliuchuan changed the title Half the default max gas amount to Half the default max gas amount to 100000 Jan 24, 2025
@heliuchuan heliuchuan closed this Jan 24, 2025
@heliuchuan heliuchuan reopened this Jan 24, 2025
@heliuchuan heliuchuan marked this pull request as ready for review January 24, 2025 11:45
@heliuchuan heliuchuan requested a review from a team as a code owner January 24, 2025 11:45
@gregnazario
Copy link
Collaborator

As I mentioned earlier, this should be configurable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants