Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Created socialmedia.html #1015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adityasingh-0803
Copy link

@adityasingh-0803 adityasingh-0803 commented Jul 7, 2024

Added socialmedia section

#937
Title : Addition of social media handles

Issue No. :#937

Code Stack :

Close #937

Description

As i have added the file as socialmedia.html in which I have make sure to add neccessary links and no misalignment is there

Video/Screenshots (mandatory)

Screenshot 2024-07-07 160631

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?
Yes

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Added socialmedia section
Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 2da1fb2
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/668a70c13ae2670008d7d2bb
😎 Deploy Preview https://deploy-preview-1015--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adityasingh-0803! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@adityasingh-0803
Copy link
Author

KIndly review it and assign the necessary taggings to fetch points thanks @apu52

@apu52 apu52 changed the title Created socialmedia.html feat: Created socialmedia.html Jul 14, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityasingh-0803 there is no code changes in this PR . what can I review???
there is only a new file u have created & I think your issue is to solve the misalignment problem of social icons in the footer so where are the necessary changes??

@apu52 apu52 added help wanted Extra attention is needed wontfix This will not be worked on labels Jul 14, 2024
@adityasingh-0803
Copy link
Author

Sir the file of this issue wasn't there so I created a new file

@apu52
Copy link
Owner

apu52 commented Jul 14, 2024

Sir the file of this issue wasn't there so I created a new file

but in this file there is no code present there .can u please explain otherwise I can't be able to understand your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation Update]: Social footer is not aligned
2 participants