Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add effect on mentioned section #1017

Merged
merged 6 commits into from
Jul 14, 2024
Merged

feat: add effect on mentioned section #1017

merged 6 commits into from
Jul 14, 2024

Conversation

Rajput-xv
Copy link
Contributor

@Rajput-xv Rajput-xv commented Jul 7, 2024

Title : add effect on mentioned section

Issue No. : #964

Code Stack :

Close #964

Description

Changes in Explore.js and Explore.css are made to achieve the hover effect on mentioned section & all the functionalities are added.

Video/Screenshots (mandatory)

Travel.website.Recording.2024-07-07.190204.mp4

Type of PR

  • Feature enhancement

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 74563d9
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6693ec3f52d95c0009c7ed02
😎 Deploy Preview https://deploy-preview-1017--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rajput-xv Rajput-xv changed the title Added hover effect on images, explore css & js file updated add effect on mentioned section Jul 7, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rajput-xv! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@Rajput-xv Rajput-xv changed the title add effect on mentioned section feat: add effect on mentioned section Jul 7, 2024
@Rajput-xv
Copy link
Contributor Author

Hello @apu52
Kindly look into this!!

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajput-xv this PR has merge conflicts .please try to resolve them faster so that I can review the code & will be able to merge it or submit a complete new PR to avoid the merging conflicts

@apu52 apu52 added the help wanted Extra attention is needed label Jul 14, 2024
@Rajput-xv
Copy link
Contributor Author

@Rajput-xv this PR has merge conflicts .please try to resolve them faster so that I can review the code & will be able to merge it or submit a complete new PR to avoid the merging conflicts

@apu52
kindly look into this now.
conflicts are resolved.

@apu52
Copy link
Owner

apu52 commented Jul 14, 2024

@Rajput-xv this PR has merge conflicts .please try to resolve them faster so that I can review the code & will be able to merge it or submit a complete new PR to avoid the merging conflicts

@apu52 kindly look into this now. conflicts are resolved.

Conflicts still present in this PR

@Rajput-xv
Copy link
Contributor Author

@Rajput-xv this PR has merge conflicts .please try to resolve them faster so that I can review the code & will be able to merge it or submit a complete new PR to avoid the merging conflicts

@apu52 kindly look into this now. conflicts are resolved.

Conflicts still present in this PR

if you merge any other PR then it will always show conflicts on my PR as i have made changes.

now i have resolved the conflicts again kindly look into it.

@apu52

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Rajput-xv why this slider is opening up as like this please change the alignment & also the paris page is still in the bg of the slider .please try to rectify the bugs

@Rajput-xv
Copy link
Contributor Author

Rajput-xv commented Jul 14, 2024

image

@Rajput-xv why this slider is opening up as like this please change the alignment & also the paris page is still in the bg of the slider .please try to rectify the bugs

will the slider in vertical position ?
as before i shared the video it was horizontal.
which alignment you want in your website ?
@apu52

@apu52
Copy link
Owner

apu52 commented Jul 14, 2024

image
@Rajput-xv why this slider is opening up as like this please change the alignment & also the paris page is still in the bg of the slider .please try to rectify the bugs

will the slider in vertical position ? as before i shared the video it was horizontal. which alignment you want in your website ? @apu52

as u have shown in the video u have shared

@Rajput-xv
Copy link
Contributor Author

Title : add effect on mentioned section

Issue No. : #964

Code Stack :

Close #964

Description

Changes in Explore.js and Explore.css are made to achieve the hover effect on mentioned section & all the functionalities are added.

Video/Screenshots (mandatory)

Travel.website.Recording.2024-07-07.190204.mp4

Type of PR

  • Feature enhancement

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24

@apu52
this was the original!
which i shared.
Now you want new or old one?

@Rajput-xv
Copy link
Contributor Author

@apu52
now alignment is corrected
look into this & merge first, then conflicts may arise.
Thanks

@apu52
Copy link
Owner

apu52 commented Jul 14, 2024

image

everything is alright in the slider but this image is not loading .please try to check it

@Rajput-xv
Copy link
Contributor Author

image

everything is alright in the slider but this image is not loading .please try to check it

this is a preview of deployment u can see the url

Recording.2024-07-14.214030.mp4

as you can see the images are loading.
you can try to refresh the page.
@apu52

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajput-xv good work

@apu52 apu52 merged commit f7944d4 into apu52:main Jul 14, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request and removed help wanted Extra attention is needed labels Jul 14, 2024
@Rajput-xv
Copy link
Contributor Author

@Rajput-xv good work

@apu52
Thank you! I'm glad you found value in my work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add effect on mentioned section
2 participants