-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add effect on mentioned section #1017
Conversation
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Rajput-xv! Thank you for your valuable contribution! Our team will review it and get back to you soon.
Hello @apu52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajput-xv this PR has merge conflicts .please try to resolve them faster so that I can review the code & will be able to merge it or submit a complete new PR to avoid the merging conflicts
@apu52 |
Conflicts still present in this PR |
if you merge any other PR then it will always show conflicts on my PR as i have made changes. now i have resolved the conflicts again kindly look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajput-xv why this slider is opening up as like this please change the alignment & also the paris page is still in the bg of the slider .please try to rectify the bugs
will the slider in vertical position ? |
as u have shown in the video u have shared |
@apu52 |
This reverts commit cc10338.
@apu52 |
this is a preview of deployment u can see the url Recording.2024-07-14.214030.mp4as you can see the images are loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajput-xv good work
@apu52 |
Title : add effect on mentioned section
Issue No. : #964
Code Stack :
Close #964
Description
Changes in Explore.js and Explore.css are made to achieve the hover effect on mentioned section & all the functionalities are added.
Video/Screenshots (mandatory)
Travel.website.Recording.2024-07-07.190204.mp4
Type of PR
Checklist:
contributing.md
file before contributing##Are you contributing under any Open-source programme?
GSSOC'24