Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redesigning section #1036

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Redesigning section #1036

wants to merge 3 commits into from

Conversation

Jasleen1210
Copy link

Title and Issue number

Title :

Issue No. : #990

Code Stack : Html css js

Close #990

Description

Changed the background, counter timer, font colors and styles of the 'wrapper' section which follows about us section on page.

Video/Screenshots (mandatory)

image

Type of PR

  • Bug fix
  • Enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Redesgining wrapper section
-> shortened counter time
-> improved the font sizes color and background of the section
forgot to edit the modal that i commented for working effeciently, fixed that in this commit
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 171b976
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/669397e086db700009897cd9
😎 Deploy Preview https://deploy-preview-1036--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jasleen1210! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@Jasleen1210 Jasleen1210 changed the title Redesigning section feat: Redesigning section Jul 9, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jasleen1210 this PR has merge conflicts .please try to resolve them faster so that I can review the code & will be able to merge it or submit a complete new PR to avoid the merging conflicts

@apu52 apu52 added the help wanted Extra attention is needed label Jul 14, 2024
@Jasleen1210
Copy link
Author

Resolved @apu52

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

it's not looking good in the website & also it is not matching with the website UI . The default design of this section is even better. I am not closing this issue .U can still make new designs on this section & submit a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesigning section
2 participants