Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved navLinks for mobile #1092

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

VijaySamant4368
Copy link
Contributor

Title and Issue number

Title : Improved navigation links for mobile

Issue No. : #1090

Code Stack :

Close #1090

Description

I made the site's navigation bar responsive for different width of mobile devices. If the device with is small, I moved the buttons from navigation bar to the Hamburger Menu. Firstly the signup/login button moves to the menu, and then the view button. The hyperlinks work there as well. Finally if the screen width is too small(350px) the logo name is removed making space for the other more required items in the navigation

Video/Screenshots (mandatory)

Before:
https://github.com/user-attachments/assets/5fe9adaf-62e9-40aa-99f2-ad8e9b49548c

After:
https://github.com/user-attachments/assets/80e4a23c-ac2a-49b4-82a3-52381911a3ff

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 0150244
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6696304741e41900094be3d7
😎 Deploy Preview https://deploy-preview-1092--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@itsekta
Copy link

itsekta commented Jul 16, 2024

Hey @VijaySamant4368, your PR looks good, just wait for some time it will be merged asap.

@VijaySamant4368
Copy link
Contributor Author

@itsekta please add the Gssoc and the level label

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VijaySamant4368 good work

@apu52 apu52 merged commit bdeb831 into apu52:main Jul 17, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request level2 gssoc labels Jul 17, 2024
@VijaySamant4368 VijaySamant4368 deleted the mobile-view branch July 17, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Better Mobile Responsive for Nav-Bar
3 participants