Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google Logo Adjustment #1101

Closed

Conversation

AshmitaBarthwal
Copy link
Contributor

@AshmitaBarthwal AshmitaBarthwal commented Jul 16, 2024

Title and Issue number

Title : Google Logo Adjustment

Issue No. : #1085

Code Stack : CSS

Close #1085

Description

Since the google logo was not visible under the translator option at the bottom of the website, So I changed the CSS properties to make it visually appealing.

Video/Screenshots (mandatory)

BEFORE:
Screenshot 2024-07-17 001104
AFTER:
Screenshot 2024-07-16 183623

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 21268a3
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6696be3c377d62000880d190
😎 Deploy Preview https://deploy-preview-1101--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 @itsekta Please review my PR and mark the LEVEL of contribution LABEL to it.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshmitaBarthwal here I can see a merge conflict & also a huge no. of deletion of commit lines . I want to suggest you to please look after your PR once again & resolve the conflicts & if possible submit a new PR

@apu52 apu52 added the help wanted Extra attention is needed label Jul 17, 2024
@AshmitaBarthwal
Copy link
Contributor Author

@apu52 CREATED A NEW PULL REQUEST

@apu52 apu52 closed this Jul 19, 2024
@apu52 apu52 added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google logo adjustment
2 participants