Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixing Login Option #1143

Closed
wants to merge 7 commits into from
Closed

Conversation

AshmitaBarthwal
Copy link
Contributor

Title and Issue number

Title : Fixing Login Option

Issue No. : #1087

Code Stack : CSS

Close #1087

Description

Added background according to light and dark mode as per website's color code to the buttons.

Video/Screenshots (mandatory)

BEFORE IN LIGHT MODE:
Screenshot 2024-07-20 162215

BEFORE IN DARK MODE:
Screenshot 2024-07-20 162200

AFTER IN LIGHT MODE:
Screenshot 2024-07-20 160027

AFTER IN DARK MODE:
Screenshot 2024-07-20 160040

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit a3e21e8
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/669d360db7c3bc00087942d7
😎 Deploy Preview https://deploy-preview-1143--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 Please review my PR.

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 Review this PR once.

@AshmitaBarthwal
Copy link
Contributor Author

@itsekta please review this PR once.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshmitaBarthwal it's good

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshmitaBarthwal but why this unnecessary commits present in this PR , as it does not have any linking with this...Please try to delete all of the unnecessary commit otherwise I can't merge this PR.
& I would like to suggest u to make different branches for different pr

@apu52 apu52 added the help wanted Extra attention is needed label Jul 21, 2024
@AshmitaBarthwal
Copy link
Contributor Author

Okay I will delete extra things

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 Please check the above changes.

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 i have deleted the unnecessary.

@AshmitaBarthwal
Copy link
Contributor Author

@apu52 Please review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing Login option
2 participants