Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nav-bar in story page #1148

Merged
merged 7 commits into from
Jul 22, 2024
Merged

fix: Nav-bar in story page #1148

merged 7 commits into from
Jul 22, 2024

Conversation

VijaySamant4368
Copy link
Contributor

@VijaySamant4368 VijaySamant4368 commented Jul 20, 2024

Title and Issue number

Title : Nav-bar in story page fixed

Issue No. : #1147

Close #1147

Description

The navigation bar in the story page(story.html) was old version, I updated it to be the latest one.

Video/Screenshots (mandatory)

image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 20, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit ff0903b
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/669e6f88f10e6f00085dc665
😎 Deploy Preview https://deploy-preview-1148--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@VijaySamant4368
Copy link
Contributor Author

@itsekta @apu52 please kindly check this out.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VijaySamant4368 there is some recent changes in the story page .please try to resolve the conflicts so that I can review the PR & will be able to merge the PR

@apu52 apu52 added the help wanted Extra attention is needed label Jul 21, 2024
@VijaySamant4368
Copy link
Contributor Author

@apu52 I resolved the conflicts.

@VijaySamant4368
Copy link
Contributor Author

Can I get a level 2 label?

@apu52
Copy link
Owner

apu52 commented Jul 22, 2024

@VijaySamant4368 after the changes u have made in the navbar of the story page the navbar is not working at all. The navbar is just static . please try to resolve it

@VijaySamant4368
Copy link
Contributor Author

I am sorry for the incontinence, I will immediately look into it.

@VijaySamant4368
Copy link
Contributor Author

@apu52 I think the problem is that the hyperlinks are wrong, I will fix it in just a moment.

@VijaySamant4368
Copy link
Contributor Author

@apu52 I have corrected the nav-links

@VijaySamant4368 VijaySamant4368 requested a review from apu52 July 22, 2024 14:15
@apu52
Copy link
Owner

apu52 commented Jul 22, 2024

@VijaySamant4368 I have checked twice , also have refreshed , but the problem is still there....u can also check in the deployed link also

@VijaySamant4368
Copy link
Contributor Author

@apu52 it should work now

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VijaySamant4368 okk Now , it's working

@apu52 apu52 merged commit 8bc0083 into apu52:main Jul 22, 2024
6 checks passed
@apu52 apu52 added bug Something isn't working level2 gssoc and removed help wanted Extra attention is needed labels Jul 22, 2024
@VijaySamant4368 VijaySamant4368 deleted the nav-bar branch July 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Old nav-bar in story.html
2 participants