Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tour Feebdback form submits without filling any information #1171 #1173

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

techy4shri
Copy link
Contributor

  • Added client-side validation for feedback form fields:
    • Required fields for name, email, and feedback comments
    • Minimum length check for feedback comments (minimum 4 characters)
    • Restriction on future dates for event date selection
  • Implemented reset functionality for star ratings after form submission

This change improves user experience by enforcing required fields and ensuring data integrity in the feedback form.

Title and Issue number

Title : [Bug]: Tour Feebdback form submits without filling any information

Issue No. : #1171

Code Stack : HTML, JavaScript

Close #1171

Description

  • Added client-side validation for feedback form fields:
    • Required fields for name, email, and feedback comments
    • Minimum length check for feedback comments (minimum 4 characters)
    • Restriction on future dates for event date selection
  • Implemented reset functionality for star ratings after form submission

This change improves user experience by enforcing required fields and ensuring data integrity in the feedback form.

Video/Screenshots (mandatory)

Tour.feedback.form.issue.-.Made.with.Clipchamp.3.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

- Added client-side validation for feedback form fields:
  - Required fields for name, email, and feedback comments
  - Minimum length check for feedback comments (minimum 4 characters)
  - Restriction on future dates for event date selection
- Implemented reset functionality for star ratings after form submission

This change improves user experience by enforcing required fields and ensuring data integrity in the feedback form.
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit b9be8f4
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/669e5d8698cf6000082a23cc
😎 Deploy Preview https://deploy-preview-1173--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@techy4shri techy4shri changed the title Added form validation and reset functionality for feedback form Fix: Tour Feebdback form submits without filling any information Issue No. #1171 Jul 22, 2024
@techy4shri techy4shri changed the title Fix: Tour Feebdback form submits without filling any information Issue No. #1171 Fix: Tour Feebdback form submits without filling any information #1171 Jul 22, 2024
@techy4shri techy4shri changed the title Fix: Tour Feebdback form submits without filling any information #1171 fix: Tour Feebdback form submits without filling any information #1171 Jul 22, 2024
@techy4shri techy4shri changed the title fix: Tour Feebdback form submits without filling any information #1171 fix: Tour Feebdback form submits without filling any information #1171 Jul 22, 2024
@techy4shri techy4shri changed the title fix: Tour Feebdback form submits without filling any information #1171 fix: Tour Feebdback form submits without filling any information #1171 Jul 22, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techy4shri great work

@apu52 apu52 merged commit 7cf1249 into apu52:main Jul 24, 2024
6 of 11 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tour Feebdback form submits without filling any information
2 participants