Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Made the changes for the google transulate #1176

Merged
merged 10 commits into from
Jul 27, 2024

Conversation

Saipradyumnagoud
Copy link
Contributor

Title and Issue number

Title :Made the changes for the google transulate

Issue No. : #1007

Code Stack : HTML CSS JS

Close #1007

Description

Added Google Transulate And styled it Properly

Video/Screenshots (mandatory)

image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit ed0b33d
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66a4f929749cb90008dff784
😎 Deploy Preview https://deploy-preview-1176--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Saipradyumnagoud
Copy link
Contributor Author

@apu52 @itsekta You can please Review it now i have made it as you told @apu52

@apu52 apu52 changed the title Made the changes for the google transulate feat: Made the changes for the google transulate Jul 24, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saipradyumnagoud sorry to say , the UI of the google translator is not looking up to the mark . like its not matching with the UI of the website .please think some other alternatives.

@apu52 apu52 added the help wanted Extra attention is needed label Jul 24, 2024
@Saipradyumnagoud
Copy link
Contributor Author

@apu52 Can you Once please Review for any chages

image

here is the new transulate

@apu52
Copy link
Owner

apu52 commented Jul 27, 2024

@Saipradyumnagoud all things are working perfect just add "GOOGLE" logo after powered by

@Saipradyumnagoud
Copy link
Contributor Author

@apu52 I have added google logo after powerd by

@apu52 apu52 merged commit 89c1d03 into apu52:main Jul 27, 2024
6 checks passed
@apu52
Copy link
Owner

apu52 commented Jul 27, 2024

@Saipradyumnagoud good work & as u already have dedicated a lot of time in this PR , I am assigning u "LAVEL 2"

@apu52 apu52 added enhancement New feature or request level2 gssoc and removed help wanted Extra attention is needed labels Jul 27, 2024
@Saipradyumnagoud
Copy link
Contributor Author

@Saipradyumnagoud good work & as u already have dedicated a lot of time in this PR , I am assigning u "LAVEL 2"

@apu52 Really very thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding Style for the google transulate
2 participants