Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance License and Acknowledgments Section and Project mentor section #1228

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

Zoha-Waheed
Copy link
Contributor

@Zoha-Waheed Zoha-Waheed commented Jul 25, 2024

Title and Issue number

Title : Enhance License and Acknowledgments Section Clarity

Issue No. : #1095

Code Stack : HTML, CSS, JS

Close #1095

Description

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit f3a24ab
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66a790a8f3e9e2000836f025
😎 Deploy Preview https://deploy-preview-1228--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zoha-Waheed Zoha-Waheed changed the title feat : Enhance License and Acknowledgments Section Clarity feat : Enhance License and Acknowledgments Section and Project mentor section Jul 25, 2024
@apu52 apu52 changed the title feat : Enhance License and Acknowledgments Section and Project mentor section feat: Enhance License and Acknowledgments Section and Project mentor section Jul 25, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zoha-Waheed can u provide here the SS of the enhanced readme after your changes??? So that I can get a clear idea

@apu52 apu52 added the question Further information is requested label Jul 25, 2024
@Zoha-Waheed
Copy link
Contributor Author

@Zoha-Waheed can u provide here the SS of the enhanced readme after your changes??? So that I can get a clear idea

yes sure, I am attaching them below
image
image
image
image

@apu52
Copy link
Owner

apu52 commented Jul 27, 2024

@Zoha-Waheed all of the changes u have made are really good , but just want one thing there is a contributor slider present now in the readme , just add it in the acknowledgement section (above the contributor list) so that I will merge this pR.

@apu52 apu52 added help wanted Extra attention is needed and removed question Further information is requested labels Jul 27, 2024
@Zoha-Waheed
Copy link
Contributor Author

@Zoha-Waheed all of the changes u have made are really good , but just want one thing there is a contributor slider present now in the readme , just add it in the acknowledgement section (above the contributor list) so that I will merge this pR.

Thanks
Just check is it so?
image

@apu52
Copy link
Owner

apu52 commented Jul 29, 2024

@Zoha-Waheed all of the changes u have made are really good , but just want one thing there is a contributor slider present now in the readme , just add it in the acknowledgement section (above the contributor list) so that I will merge this pR.

Thanks Just check is it so? image

yess .Now push this changes in this PR & ping me here after that , then I will merge this PR.

@Zoha-Waheed Zoha-Waheed mentioned this pull request Jul 29, 2024
11 tasks
@Zoha-Waheed
Copy link
Contributor Author

@Zoha-Waheed all of the changes u have made are really good , but just want one thing there is a contributor slider present now in the readme , just add it in the acknowledgement section (above the contributor list) so that I will merge this pR.

Thanks Just check is it so? image

yess .Now push this changes in this PR & ping me here after that , then I will merge this PR.

Changes are already committed in this PR. Anything else, then sure.

@apu52 apu52 merged commit b4204e5 into apu52:main Jul 29, 2024
6 checks passed
@apu52
Copy link
Owner

apu52 commented Jul 29, 2024

@Zoha-Waheed Thanks for your valuable contribution.

@apu52 apu52 added enhancement New feature or request level1 gssoc and removed help wanted Extra attention is needed labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance License and Acknowledgments Section Clarity
2 participants