Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dark mode in membership page #1229

Merged
merged 5 commits into from
Jul 29, 2024

Conversation

ANKeshri
Copy link
Contributor

Title and Issue number

Title : dark mode in membership page

Issue No. :#1214

Code Stack :

Close #1214

Description

dark mode feature in membership page

Video/Screenshots (mandatory)

Recording.2024-07-25.162202.mp4

Type of PR

  • Feature enhancement

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit af4ec32
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66a767aef99d460008e7c05d
😎 Deploy Preview https://deploy-preview-1229--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ANKeshri
Copy link
Contributor Author

@apu52 please review once and merge my pr

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ANKeshri the color scheme of the dark mode of the booking page u have added is not matching with the other parts of the website & also it's not catchy for the users also , please try to improve it with better UI

@apu52 apu52 added the help wanted Extra attention is needed label Jul 25, 2024
@ANKeshri
Copy link
Contributor Author

@apu52 can you please suggest me what changes you want as i have given same toggke for dark and light mide and in no particular pahe there is dark mode from where i could take reference

@apu52
Copy link
Owner

apu52 commented Jul 25, 2024

@ANKeshri please try to look at the UI of the main website at dark mode check the color schemes . You can take reference from that . Actually In the dark mode u have made it's simply black color UI so I wanted u to enhance it .

@ANKeshri
Copy link
Contributor Author

ANKeshri commented Jul 29, 2024

@apu52 made the dark mode according to theme (taken refernce from home page testimonial)

image

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ANKeshri good work

@apu52 apu52 merged commit ddda4f8 into apu52:main Jul 29, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request level1 gssoc and removed help wanted Extra attention is needed labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: dark mode for membership page
2 participants