Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update plantrip.html #1279

Merged
merged 4 commits into from
Aug 5, 2024
Merged

feat: Update plantrip.html #1279

merged 4 commits into from
Aug 5, 2024

Conversation

sau-mili
Copy link
Contributor

@sau-mili sau-mili commented Jul 30, 2024

Title and Issue number

Title : Updated plan a trip page

Issue No. : #1261

Code Stack : HTML, CSS, JS

Close #1261

Description

Video/Screenshots (mandatory)

Screenshot 2024-07-30 220953

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 5ef92b5
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66b0c54eef1c930008883b8f
😎 Deploy Preview https://deploy-preview-1279--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sau-mili sau-mili changed the title Update plantrip.html feat: Update plantrip.html Jul 30, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

the UI of the plan trip page is not looking professional , please try to enhance the UI

@apu52 apu52 added the help wanted Extra attention is needed label Aug 2, 2024
@sau-mili
Copy link
Contributor Author

sau-mili commented Aug 2, 2024

Okay. I will update it by tomorrow

@sau-mili
Copy link
Contributor Author

sau-mili commented Aug 4, 2024

Please check now. I have Updated the page.

  • added new background
  • new navbar
  • form UI updated
  • added caution if not input is added
  • added a trip suggesting carousel
    Screenshot 2024-08-05 014041
    Screenshot 2024-08-05 014052
    Screenshot 2024-08-05 014106
    Screenshot 2024-08-05 014120

@apu52
Copy link
Owner

apu52 commented Aug 5, 2024

@sau-mili this pR has some merge conflicts , please try to resolve the conflicts , so that I can review the code & will be able to merge the PR.

@sau-mili
Copy link
Contributor Author

sau-mili commented Aug 5, 2024

i will resolve it in 5 minutes

@sau-mili
Copy link
Contributor Author

sau-mili commented Aug 5, 2024

Please check now

@apu52 apu52 merged commit c9ef1c6 into apu52:main Aug 5, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request level2 gssoc and removed help wanted Extra attention is needed labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Improve Plan a trip page
2 participants