Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Login without validating any email or password #1289

Conversation

anwesha2002
Copy link

@anwesha2002 anwesha2002 commented Aug 1, 2024

Title and Issue number

Title : Login without entering any email or password
Issue No. : #1135

Code Stack : HTML, CSS, JS

Close #1135

Description

This PR adds a new feature of validation check for email and password in the frontend, matching the registered email and password if matched then successful login otherwise blocked
If user is registered with the same email then blocks the re-registering with the same email
Added a blocked banner like success banner

Video/Screenshots (mandatory)

Recording.2024-08-01.083328.mp4
Recording.2024-08-01.083534.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): __None ______

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 1ca1653
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66aafc4d9580d000080d54be
😎 Deploy Preview https://deploy-preview-1289--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anwesha2002! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@anwesha2002 anwesha2002 changed the title Feat/login without validated credentials fixed frontend [Bug]: Login without entering any email or password Aug 1, 2024
@anwesha2002 anwesha2002 changed the title [Bug]: Login without entering any email or password [Bug]: Login without validating any email or password Aug 1, 2024
@anwesha2002 anwesha2002 changed the title [Bug]: Login without validating any email or password fix: Login without validating any email or password Aug 1, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anwesha2002 good work

@apu52 apu52 merged commit 303b127 into apu52:main Aug 2, 2024
7 of 12 checks passed
@apu52 apu52 added bug Something isn't working level2 gssoc labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Login without entering any email or password
2 participants