Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the packages page #1313

Merged
merged 2 commits into from
Aug 5, 2024
Merged

feat: added the packages page #1313

merged 2 commits into from
Aug 5, 2024

Conversation

ayush-848
Copy link
Contributor

Title and Issue number

Title : added the packages page

Issue No. : #1297

Code Stack : HTML, CSS, JS

Close #1297

Description

  • added a packages page
  • added the navbar in it
  • added trips, hotel and pricing sections
  • added a video background with a proper overlay
  • added few fade and hover effects

Video/Screenshots (mandatory)

https://www.awesomescreenshot.com/video/30174347?key=af98b0f456970bdcc93d9e643a9e9e02

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [x I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit f2c8d03
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66afd396bfadeb0008ce9644
😎 Deploy Preview https://deploy-preview-1313--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ayush-848
Copy link
Contributor Author

@apu52 please check this. I have put a lot of efforts in the layout and styling

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

all the changes u have made are really good . But the pricing in the INR section is not showing up properly. please try to fix this issue .

@apu52 apu52 added the help wanted Extra attention is needed label Aug 4, 2024
@ayush-848
Copy link
Contributor Author

image

all the changes u have made are really good . But the pricing in the INR section is not showing up properly. please try to fix this issue .

Ok

@ayush-848
Copy link
Contributor Author

image
@apu52 I will fix the pricing and functionalities and links every thing in #1318

@ayush-848
Copy link
Contributor Author

@apu52 for now merge this PR

@ayush-848 ayush-848 requested a review from apu52 August 4, 2024 19:19
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayush-848 good work

@apu52 apu52 merged commit c2531e8 into apu52:main Aug 5, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request level3 gssoc and removed help wanted Extra attention is needed labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Making a new page Popular Packages
2 participants