Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change Footer Alignment and Color Contrast #1315

Merged
merged 3 commits into from
Aug 4, 2024
Merged

Conversation

lovelymahor
Copy link
Contributor

@lovelymahor lovelymahor commented Aug 4, 2024

Please review this changes and approve #1245

Title :

Issue No. : #1245

Code Stack :

Close #1245

Description

This pull request addresses the need to improve the footer's alignment and color contrast to enhance readability and overall design consistency.

Video/Screenshots (mandatory)

Before

Screenshot (332)

After

Screenshot (334)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

Please review the changes and let me know if there are any further adjustments needed. I am open to feedback and suggestions to make sure the footer meets our design and functionality standards.

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Aug 4, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit ae474ac
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66af6410fa1ce90008070bc2
😎 Deploy Preview https://deploy-preview-1315--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lovelymahor
Copy link
Contributor Author

Hello @apu52 ,
Please review the changes at your earliest convenience and consider merging them. Thank you!

@lovelymahor lovelymahor changed the title Change Footer Alignment and Color Contrast (#1245) Change Footer Alignment and Color Contrast Aug 4, 2024
@lovelymahor
Copy link
Contributor Author

Hey @KrishnenduDG
please review it

@apu52 apu52 changed the title Change Footer Alignment and Color Contrast fix: Change Footer Alignment and Color Contrast Aug 4, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lovelymahor good work

@apu52 apu52 merged commit ecaeaef into apu52:main Aug 4, 2024
6 of 8 checks passed
@apu52 apu52 added enhancement New feature or request level1 gssoc labels Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Footer Alignment
2 participants