Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add in css in class link #1362

Closed
wants to merge 3 commits into from
Closed

fix: add in css in class link #1362

wants to merge 3 commits into from

Conversation

YashMall
Copy link

@YashMall YashMall commented Aug 9, 2024

Title and Issue number

Title : Added font-size, border-Shadow, Padding, margins to make sure the that the header and the hotel.html page looks much better clear.

Issue No. : #1066

Code Stack : HTML, CSS, JS

Close :

Description

I have added a font size attribute so that to make the website detailing more enhanced and clearly make the header text visible.

I have also made changes in Hotel.html page where I have made form looks more better and made made that Home button look bigger so that it fits in the page much better.

Video/Screenshots (mandatory)

image
image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 8c1ba13
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66b6527b661315000860aa64
😎 Deploy Preview https://deploy-preview-1362--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YashMall! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@YashMall YashMall changed the title change in css in class link add in css in class link Aug 9, 2024
@apu52 apu52 changed the title add in css in class link fix: add in css in class link Aug 9, 2024
@apu52
Copy link
Owner

apu52 commented Aug 9, 2024

@YashMall what is your assigned issue no??? Can u please mention

@apu52 apu52 added the question Further information is requested label Aug 9, 2024
@YashMall
Copy link
Author

YashMall commented Aug 9, 2024

@apu52 hey, I have just made the header look better by increasing the font size I have no issue no. to it. I was just observing the website and I thought to change it so it looks better.

I have also made changes in Hotel.html page where I have made form looks more better and made made that Home button look bigger so that it fits in the page much better.

Please see to it as I'm happy to contribute and tomorrow is last date for GGSOC'24

@apu52
Copy link
Owner

apu52 commented Aug 10, 2024

@YashMall I HAVE SEEN your changes . But if u haven't make any type of issue for this PR , I can't assign you this PR. As per the rule of this repo first u have to make a issue & then only after u get assigned , u can submit your PR. So despite your changes , I have to close this PR as unplanned, At first u have to go through the contributing.md file before contributing.

@apu52 apu52 closed this Aug 10, 2024
@apu52 apu52 added invalid This doesn't seem right and removed question Further information is requested labels Aug 10, 2024
@YashMall
Copy link
Author

@apu52 Hello, i have added the issue no. Kindly check to it, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants