Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deleted outdated files which are no longer used.(fixes issue#1482) #1537

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

Nivesh2003
Copy link
Contributor

@Nivesh2003 Nivesh2003 commented Oct 20, 2024

chore: deleted outdated files which are no longer used.(fixes issue #1482 )

Title : chore: Deleted outdated files from the codebase (fixes issue #1482)

Issue No. : 1482

Code Stack : html

Close #1482

Description

I deleted some outdated files as i mentioned in the issue.

Video/Screenshots (mandatory)

Screenshot 2024-10-20 140004

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______Code base update ________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit ab017ab
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6714c161d0a6920008cf3261
😎 Deploy Preview https://deploy-preview-1537--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nivesh2003! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@Nivesh2003
Copy link
Contributor Author

why title needs formatting ? What does that means

@rishika105
Copy link
Contributor

chore: deleted outdated files which are no longer used.(fixes issue #1537)
Try this as title.

@Nivesh2003
Copy link
Contributor Author

@rishika105 hello i put that title

@rishika105
Copy link
Contributor

you need to put that title at above the main title that is highlighed above PR title. Look there will be option to edit change it there and add that full title just copy the below line full and try it.
chore: deleted outdated files which are no longer used.(fixes issue #1537)

@Nivesh2003
Copy link
Contributor Author

ok did that but still failing

@rishika105
Copy link
Contributor

rishika105 commented Oct 20, 2024

No you havent done it. Change the main title . And write the correct issue number. look at my PR. I have used feat and then title . You should use chore as AI says.

@Nivesh2003
Copy link
Contributor Author

I did as same as you please tell me the part which is wrong here
Screenshot 2024-10-20 215319

@rishika105
Copy link
Contributor

rishika105 commented Oct 20, 2024

image
Change this title to :
chore: deleted outdated files which are no longer used.(fixes issue#1537)
check your issue number add yours.

@rishika105
Copy link
Contributor

rishika105 commented Oct 20, 2024

image
Look like this. There is the edit button at the right of your PR title. There click and edit it.

@Nivesh2003 Nivesh2003 changed the title Deleted some outdated files which were no longer used chore: deleted outdated files which are no longer used.(fixes issue#1482) Oct 20, 2024
@Nivesh2003
Copy link
Contributor Author

I was doing something else till yet omg , thank you for clearing it , I really appreciate your help @rishika105

@rishika105
Copy link
Contributor

I was doing something else till yet omg , thank you for clearing it , I really appreciate your help @rishika105

Welcome:)

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nivesh2003 thanks for the contribution

@apu52 apu52 merged commit 7ab4853 into apu52:main Oct 26, 2024
6 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Outdated files
3 participants