-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed-directing-to-different-pages-from-plan-a-trip-page-and-image-slider-to-stop-when-it-reaches-the-last-image #1588
Conversation
…ider-to-stop-when-it-reaches-the-last-image
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arveti-likhitha this pr is facing some merge conflicts please try to resolve this so that I can review & merge this pr
ASAP
@apu52 I have made changes. Can you check and let me know if there are any conflicts? |
@Arveti-likhitha the conflicts are still present in this repo , please try to resolve them asap |
@apu52 I resolved all the conflicts except for one. There is a conflict with the part of the code which is not present in the "index.html" file. So I am not able to resolve the conflict. Could you guide me on how to resolve this? |
@Arveti-likhitha u can do one thing , try to close this PR for now , |
Title : Enhancing Plan a trip page
Issue No. : #1493
Code Stack : HTML, CSS, JS
Close #1493
Description
Made changes to make sure they are navigating to the correct pages and changing the image slider such that navigation stops after it reaches the last image card.
Video/Screenshots (mandatory)
Screen.Recording.2024-10-29.103335.mp4
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
##Are you contributing under any Open-source programme?
No
GSSOC'24 Extended
Hacktoberfest'24