Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed-directing-to-different-pages-from-plan-a-trip-page-and-image-slider-to-stop-when-it-reaches-the-last-image #1588

Conversation

Arveti-likhitha
Copy link
Contributor

@Arveti-likhitha Arveti-likhitha commented Oct 29, 2024

Title : Enhancing Plan a trip page

Issue No. : #1493

Code Stack : HTML, CSS, JS

Close #1493

Description

Made changes to make sure they are navigating to the correct pages and changing the image slider such that navigation stops after it reaches the last image card.

Video/Screenshots (mandatory)

Screen.Recording.2024-10-29.103335.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

No

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 4059143
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6722008c76ba3600080cd44c
😎 Deploy Preview https://deploy-preview-1588--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Arveti-likhitha Arveti-likhitha changed the title fixed-directing-to-different-pages-from-plan-a-trip-page-and-image-slider-to-stop-when-it-reaches-the-last-image fix: Enhancing Plan a trip page Oct 29, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arveti-likhitha this pr is facing some merge conflicts please try to resolve this so that I can review & merge this pr
ASAP

@apu52 apu52 added the help wanted Extra attention is needed label Oct 29, 2024
@Arveti-likhitha Arveti-likhitha changed the title fix: Enhancing Plan a trip page fix: fixed-directing-to-different-pages-from-plan-a-trip-page-and-image-slider-to-stop-when-it-reaches-the-last-image Oct 30, 2024
@Arveti-likhitha
Copy link
Contributor Author

@apu52 I have made changes. Can you check and let me know if there are any conflicts?

@apu52
Copy link
Owner

apu52 commented Oct 30, 2024

@Arveti-likhitha the conflicts are still present in this repo , please try to resolve them asap

@Arveti-likhitha
Copy link
Contributor Author

@apu52 I resolved all the conflicts except for one. There is a conflict with the part of the code which is not present in the "index.html" file. So I am not able to resolve the conflict.

Could you guide me on how to resolve this?

@apu52
Copy link
Owner

apu52 commented Oct 30, 2024

@Arveti-likhitha u can do one thing , try to close this PR for now ,
Try to make a new branch on your forked repo & then make all of your proposed changes in that branch & try to push all of your commits in that branch & make/submit a new pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enhancing Plan a trip page
2 participants