Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhanced plantrip page #1598

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Conversation

Arveti-likhitha
Copy link
Contributor

Title and Issue number

Title : Enhanced plan trip page

Issue No. : #1493

Code Stack : HTML, CSS, JS

Close #1493

Description

Made changes to make sure they are navigating to the correct pages and changing the image slider such that navigation stops after it reaches the last image card.

Video/Screenshots (mandatory)

Screen.Recording.2024-10-29.103335.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit c1f79e3
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6723731484a48300085834c9
😎 Deploy Preview https://deploy-preview-1598--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arveti-likhitha this pr is facing some merge conflicts please try to resolve this so that I can review & merge this PR
try to update your branch(sync fork) at first then push your commits , maybe then u can avoid the conflicts

@apu52 apu52 added the help wanted Extra attention is needed label Oct 31, 2024
@Arveti-likhitha
Copy link
Contributor Author

@apu52 All the conflicts are resolved.

@apu52
Copy link
Owner

apu52 commented Oct 31, 2024

@Arveti-likhitha still has conflicts

@Arveti-likhitha
Copy link
Contributor Author

@apu52 All clear now.
image

Sorry for the trouble. There were no conflicts when commented earlier, don't know how there was a conflict again.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arveti-likhitha okk great contribution . & really great dedication that u have crossed so much obstacles of the conflict merging problem

@apu52 apu52 merged commit 1f975d5 into apu52:main Oct 31, 2024
5 checks passed
@apu52 apu52 added hacktoberfest-accepted gssoc-ext and removed help wanted Extra attention is needed labels Oct 31, 2024
Copy link

🎉🎉 Thank you for your contribution! Your PR #1598 has been merged! 🎉🎉

@apu52 apu52 added the level2 label Oct 31, 2024
@Arveti-likhitha
Copy link
Contributor Author

@apu52 Thank you for your patience with me. Wishing you all the best and hoping to contribute to your projects in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enhancing Plan a trip page
2 participants