-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enhanced plantrip page #1598
Conversation
…ider-to-stop-when-it-reaches-the-last-image
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arveti-likhitha this pr is facing some merge conflicts please try to resolve this so that I can review & merge this PR
try to update your branch(sync fork) at first then push your commits , maybe then u can avoid the conflicts
@apu52 All the conflicts are resolved. |
@Arveti-likhitha still has conflicts |
@apu52 All clear now. Sorry for the trouble. There were no conflicts when commented earlier, don't know how there was a conflict again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arveti-likhitha okk great contribution . & really great dedication that u have crossed so much obstacles of the conflict merging problem
🎉🎉 Thank you for your contribution! Your PR #1598 has been merged! 🎉🎉 |
@apu52 Thank you for your patience with me. Wishing you all the best and hoping to contribute to your projects in the future. |
Title and Issue number
Title : Enhanced plan trip page
Issue No. : #1493
Code Stack : HTML, CSS, JS
Close #1493
Description
Made changes to make sure they are navigating to the correct pages and changing the image slider such that navigation stops after it reaches the last image card.
Video/Screenshots (mandatory)
Screen.Recording.2024-10-29.103335.mp4
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24 Extended
Hacktoberfest'24