Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer_Fixed #648

Closed
wants to merge 5 commits into from
Closed

Footer_Fixed #648

wants to merge 5 commits into from

Conversation

abhayvershwal
Copy link

@abhayvershwal abhayvershwal commented May 28, 2024

issue no:#559

Close #559

Video/Screenshots (mandatory)

Recording.2024-05-29.013704.mp4

image

The FAQ and Terms & Conditions links are now vertically aligned. Additionally, all elements in the footer have same hover effect and Event the contact us link is responsive and redirect the page to the contact us page

Are you contributing under any Open-source programme?
GSSOC24

…sponsive and redirect the page to the contact us page
…is responsive and rediret us to the contact us page
Copy link

netlify bot commented May 28, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 77966c2
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/665eb61f05031d0007866836
😎 Deploy Preview https://deploy-preview-648--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abhayvershwal abhayvershwal changed the base branch from main to New May 28, 2024 20:12
@abhayvershwal abhayvershwal changed the base branch from New to Update May 28, 2024 20:13
@abhayvershwal abhayvershwal changed the base branch from Update to main May 28, 2024 20:15
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhayvershwal this PR has merge conflicts .please take a look in the PR & resolve the merge conflicts so that I can review & merge the PR

@apu52 apu52 added help wanted Extra attention is needed question Further information is requested labels Jun 1, 2024
@abhayvershwal abhayvershwal requested a review from apu52 June 4, 2024 06:38
@abhayvershwal
Copy link
Author

@apu52 I've made the requested changes and all checks have passed. Please review my code now
Thank you!!

@abhayvershwal
Copy link
Author

abhayvershwal commented Jun 4, 2024

@apu52 Also please assign this issue the label of GSSOC 2024

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The footer is not present in this PR maybe due to conflicts & it's really messed up .i would like to recommend to make a new branch (update the branch) & push all of your changes to make the PR

image

@apu52 apu52 closed this Jun 4, 2024
@apu52 apu52 added the wontfix This will not be worked on label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature_Request] issue with the footer
2 participants