Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor theme toggle logic and update styles #718

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

adityas-github
Copy link
Contributor

Fixed Subscribe Button Hover Effect and Theme Style Update

Title: No Hover Effect on Subscribe Button and Theme Style Not Changing

Issue No. : #659

Code Stack: HTML, CSS, JS

Close #659

Description

This pull request resolves two bugs with the subscribe button on the website that were identified earlier. I've fixed both problems, including adding a hover effect to the subscribe button and ensuring that its style updates appropriately when toggling the theme of the page.

Video/Screenshots (mandatory)

video1.mp4

Type of PR

  • Bug fix

Checklist:

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Are you contributing under any Open-source program?

Yes, it is GSSoC 2024

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit ba501f1
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/665de56367e9a200087310a2
😎 Deploy Preview https://deploy-preview-718--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adityas-github! Thank you for your valuable contribution! Our team will review it and get back to you soon.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adityas-github good changes . Thanks for your valid contribution.

@apu52 apu52 merged commit 77140c3 into apu52:main Jun 5, 2024
5 checks passed
@apu52 apu52 added enhancement New feature or request level1 gssoc labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Hover Effect on Subscribe Button and Theme Style Not Changing
2 participants