Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Images added in the Explore top destinations section #586 #760

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: Images added in the Explore top destinations section #586 #760

merged 1 commit into from
Jun 6, 2024

Conversation

nidhipai78
Copy link
Contributor

@nidhipai78 nidhipai78 commented Jun 5, 2024

Title and Issue number

Title : Images added in the Explore top destinations section

Issue No. : #586

Code Stack : HTML | CSS

Close #586

Description

Images for each of the destinations are added in the explore top destinations section. Along with it, the background of each card is added with the same image.

Screenshots

image

Type of PR

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

Since the old PR had merge conflicts this is a new PR. The old PR is #705.

Are you contributing under any Open-source programme?
I am a GSSOC'24 Contributor

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit ab647a7
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66607b7d2d29a400082b9a0e
😎 Deploy Preview https://deploy-preview-760--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@apu52 apu52 changed the title Images added in the Explore top destinations section #586 bug: Images added in the Explore top destinations section #586 Jun 6, 2024
@apu52 apu52 changed the title bug: Images added in the Explore top destinations section #586 fix: Images added in the Explore top destinations section #586 Jun 6, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nidhipai78 thanks for your valid contribution.

@apu52 apu52 merged commit d039aac into apu52:main Jun 6, 2024
6 of 10 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc labels Jun 6, 2024
@nidhipai78 nidhipai78 deleted the images branch June 7, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:No images in the "Explore Top Destination" section
2 participants