Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Footer UI #768

Closed
wants to merge 3 commits into from
Closed

Update Footer UI #768

wants to merge 3 commits into from

Conversation

Mubashir2611
Copy link
Contributor

@Mubashir2611 Mubashir2611 commented Jun 5, 2024

feat:Adding better UI in footer section #637

Title:feat:Adding better UI in footer section #637

Issue No. :#637

Code Stack :

Close #<issue_no>

Description

**Hey @apu52 I change the website footer user interface that is looked user friendly for the user. My changes included in this issue are:

  1. Cahnge the footer section background by gradient color if the user hover into the section.
  2. Change the better interface of that section, Included Social Media icons in that section for better user interactivity.** I would like to review my PR and merge it kindly.

Video/Screenshots (mandatory)

image

Screen.Recording.-.Made.with.FlexClip.1.webm

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

Are you contributing under any Open-source programme?

Yes

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit bf4fc08
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6660b4eefbf9600008537675
😎 Deploy Preview https://deploy-preview-768--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mubashir2611 Mubashir2611 mentioned this pull request Jun 5, 2024
9 tasks
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mubashir2611 this PR has merge conflicts .I would like to suggest you to update your branch at first & then submit your PR , Closing this PR for now , & waiting for your new PR

@apu52 apu52 closed this Jun 6, 2024
@apu52 apu52 added wontfix This will not be worked on and removed title needs formatting labels Jun 6, 2024
@Mubashir2611 Mubashir2611 deleted the FooterUI branch June 7, 2024 07:47
@Mubashir2611
Copy link
Contributor Author

Mubashir2611 commented Jun 7, 2024

@apu52 What should I do then tell me? Why this happened all the time! And you close my pr?!

@apu52
Copy link
Owner

apu52 commented Jun 7, 2024

@apu52 What should I do then tell me? Why this happened all the time! And you close my pr?!

Actually someone else /another contributor is also working on other issues with Footer , that's why the conflicts are constantly arising in your PR & I am closing your PR on the account that You will not face any type of conflicts farther ,

Just want to suggest u just update your branch/ make a new branch & push all of the changes there , now I think u will not face any type of conflicts .

Eager to see your PR .HAPPY CODING !!!!!!!!!!!!!

@Mubashir2611
Copy link
Contributor Author

Please next time don't close my PR's.I work alot for those PR's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
title needs formatting wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants