Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated feedback.js to accept only non-zero ratings #807

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

NidhiTornekar
Copy link
Contributor

Title and Issue number

Title :Accepts zero star ratings

Issue No. :745

Code Stack : Javascript

Close #745

Description

Added additional functionality to accept only non-zero ratings in the "Rate our Service" page.
Also, made sure that after successful submission, the ratings and feedback are set back to default settings(that is zero stars and empty feedback)

Video/Screenshots (mandatory)

ss7

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

Contributing under GSSOC 2024.
Please assign corresponding level tag also.

Added additional functionality to accept only non-zero ratings in the "Rate our Service" page.
Updated feedback.js to accept only non-zero ratings
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit fe9101d
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6663544722e0190008b84857
😎 Deploy Preview https://deploy-preview-807--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NidhiTornekar! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@NidhiTornekar NidhiTornekar changed the title Updated feedback.js to accept only non-zero ratings fix: Updated feedback.js to accept only non-zero ratings Jun 7, 2024
@NidhiTornekar
Copy link
Contributor Author

@apu52 Please review the PR.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NidhiTornekar that's really good

@apu52 apu52 merged commit a3a5167 into apu52:main Jun 26, 2024
6 of 7 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accepts zero star ratings
2 participants