Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed mobile view of home page #818

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix: fixed mobile view of home page #818

merged 2 commits into from
Jul 2, 2024

Conversation

dhairyagothi
Copy link
Contributor

@dhairyagothi dhairyagothi commented Jun 8, 2024

Title and Issue number

Title : BUG fixing css of home page in mobile view

Issue No. : #790

Code Stack :

Close #790

Description

Video/Screenshots (mandatory)

before:
image

after:
image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 533f41c
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6683b94afcfe7f0008b4e9f4
😎 Deploy Preview https://deploy-preview-818--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dhairyagothi! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@dhairyagothi
Copy link
Contributor Author

@apu52 please merge this PR

@dhairyagothi
Copy link
Contributor Author

@apu52 Please check PR and merge it

@dhairyagothi
Copy link
Contributor Author

Please merge the PR @apu52

@dhairyagothi
Copy link
Contributor Author

@apu52 please merge the PR with gssoc label

@apu52 apu52 changed the title fixed mobile view of home page fix: fixed mobile view of home page Jun 26, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhairyagothi there is some recent changes in the website page so that your PR is facing some merging conflicts . so I would like to request you to submit a new PR making a new branch in your forked PR to avoid all of the conflicts
Otherwise the features u have added are working well .I have checked it

@apu52 apu52 added the help wanted Extra attention is needed label Jun 26, 2024
@dhairyagothi
Copy link
Contributor Author

Okay i will make

@dhairyagothi
Copy link
Contributor Author

done @apu52 check it

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhairyagothi good work

@apu52 apu52 merged commit f184fe0 into apu52:main Jul 2, 2024
6 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc and removed help wanted Extra attention is needed labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG fixing css of home page in mobile view
2 participants