Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Total amount remains same irrespective of the package selected #781 #832

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

techy4shri
Copy link
Contributor

@techy4shri techy4shri commented Jun 8, 2024

Updated payment html and javascript files to display total cost as per the selected package on the checkout page.
This does not affect the page or the website as a whole.

See #781

Title and Issue number

Title : Total amount remains same irrespective of the package selected #781

Issue No. : 781

Code Stack : JavaScript

Close #781

Description

Updated and edited the payment html and javascript file, removing the static value and replacing it with the variable to update the total cost on the checkout page as per the selected package.

Video/Screenshots (mandatory)

BEFORE CHANGE:
Screenshot 2024-06-06 210844
Screenshot 2024-06-06 210857
Screenshot 2024-06-06 210913

AFTER CHANGE:
image
Screenshot 2024-06-06 210857
Screenshot 2024-06-06 210913

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

Yes, I am contributing under GSSOC 2024.

This does not affect the page or the website as a whole.

See apu52#781
Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 671bdd3
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6664a11116ef150008de9d74
😎 Deploy Preview https://deploy-preview-832--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @techy4shri! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@techy4shri techy4shri changed the title Updated payment page to display total cost as per the selected package. Total amount remains same irrespective of the package selected #781 Jun 8, 2024
@techy4shri techy4shri changed the title Total amount remains same irrespective of the package selected #781 Total amount remains same irrespective of the package selected Jun 8, 2024
@techy4shri techy4shri changed the title Total amount remains same irrespective of the package selected Fix: Total amount remains same irrespective of the package selected Jun 8, 2024
@techy4shri techy4shri changed the title Fix: Total amount remains same irrespective of the package selected BUG: Total amount remains same irrespective of the package selected #781 Jun 8, 2024
@techy4shri techy4shri changed the title BUG: Total amount remains same irrespective of the package selected #781 Fix: Total amount remains same irrespective of the package selected #781 Jun 8, 2024
@techy4shri techy4shri changed the title Fix: Total amount remains same irrespective of the package selected #781 fix: Total amount remains same irrespective of the package selected #781 Jun 8, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techy4shri okkk..good changes

@apu52 apu52 merged commit c24ea33 into apu52:main Jun 26, 2024
7 of 13 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Total amount remains same irrespective of the package selected
2 participants