Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom cursor added (issue : #772) #836

Closed
wants to merge 2 commits into from

Conversation

chaanakyaaM
Copy link
Contributor

Title and Issue number

Title :Custom Cursor

Issue No. : #772

Code Stack : HTML, CSS , JS

Close #772

Description

I have added the custom cursor.

Video/Screenshots (mandatory)

curor.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
    <!- [X] - put a cross/X inside [] to check the box -->

Additional context:

##Are you contributing under any Open-source programme?

GSSOC'24

Copy link

netlify bot commented Jun 9, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 528636d
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/667ecfb64ae13700085998dd
😎 Deploy Preview https://deploy-preview-836--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chaanakyaaM! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@chaanakyaaM chaanakyaaM changed the title custom cursor added Feat: custom cursor added Jun 10, 2024
@chaanakyaaM
Copy link
Contributor Author

Let me know if there are any changes to be made.

@chaanakyaaM chaanakyaaM changed the title Feat: custom cursor added Feat: custom cursor added (issue : #772) Jun 13, 2024
@chaanakyaaM
Copy link
Contributor Author

would do please review this PR.

@chaanakyaaM chaanakyaaM changed the title Feat: custom cursor added (issue : #772) feat: custom cursor added (issue : #772) Jun 13, 2024
@chaanakyaaM
Copy link
Contributor Author

Please review this PR.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaanakyaaM there is some recent changes in the website page so that your PR is facing some merging conflicts . so I would like to request you to submit a new PR making a new branch in your forked PR to avoid all of the conflicts
Otherwise the features u have added are working well .I have checked it

@apu52 apu52 added the help wanted Extra attention is needed label Jun 26, 2024
@chaanakyaaM
Copy link
Contributor Author

Sure

@chaanakyaaM
Copy link
Contributor Author

@apu52 kindly review this PR.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaanakyaaM this PR still have merge conflicts & Just I have notices that tis website already has a custom Cursor . So I think There is no need for this PR now .Hope u will understand .I want to suggest u to close this PR & look forward for farther more issues in this project.

@chaanakyaaM
Copy link
Contributor Author

sure

@chaanakyaaM chaanakyaaM closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature_Request: Custom cursor
2 participants