Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added functionality to Login button #864

Closed
wants to merge 3 commits into from

Conversation

samarsajad
Copy link
Contributor

Title and Issue number

Title :

Issue No. : #764

Code Stack :
html
css
javaScript

Close #764

Description

The login button was not functional. Now it successfully redirects to the homepage

Video/Screenshots (mandatory)

tourguide.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

GSSoC'24

##Are you contributing under any Open-source programme?

GSSoC'24

@samarsajad
Copy link
Contributor Author

Please review my pull request @apu52

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit c1276cf
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/667d22cba523120008742cd5
😎 Deploy Preview https://deploy-preview-864--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samarsajad there is some recent changes in the website page so that your PR is facing some merging conflicts . so I would like to request you to submit a new PR making a new branch in your forked PR to avoid all of the conflicts
Otherwise the features u have added are working well .I have checked it

@apu52 apu52 changed the title Added functionality to Login button feat: Added functionality to Login button Jun 26, 2024
@apu52 apu52 added help wanted Extra attention is needed title needs formatting labels Jun 26, 2024
@samarsajad
Copy link
Contributor Author

@samarsajad there is some recent changes in the website page so that your PR is facing some merging conflicts . so I would like to request you to submit a new PR making a new branch in your forked PR to avoid all of the conflicts Otherwise the features u have added are working well .I have checked it

I created a new PR #924 as requested. Please check it out @apu52

@apu52 apu52 closed this Jul 2, 2024
@apu52 apu52 added duplicate This issue or pull request already exists and removed help wanted Extra attention is needed labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log in button redirects to log in page
2 participants