-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added social media links #893
Conversation
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Saipradyumnagoud! Thank you for your valuable contribution! Our team will review it and get back to you soon.
@apu52 can you please review soon |
@itsekta can you please review it 🙏🏾 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saipradyumnagoud there is some recent changes in the website page so that your PR is facing some merging conflicts . so I would like to request you to submit a new PR making a new branch in your forked PR to avoid all of the conflicts
Otherwise the features u have added are working well .I have checked it
@apu52 Now please go through the pull request |
Hey @Saipradyumnagoud, can you also improve the UI a little bit by adding gap between them, keep the icon color to white and on hovering over the icons change the color of the icons to their default icon instead of white only. Suppose Facebook icon color is blue (#1877F2) by default the icons are white only but on hovering over the facebook icon the color should be #1877F2. Similar for all the icons, checkout the colors for other icons as well |
Yes sure i will work on it |
@Saipradyumnagoud, why are the icons getting smaller on hover |
Should i make icons bigger on hover |
Your choice, you can make a little bigger (scale 0.5) or don't just the ui should look nice. |
@itsekta yes now i have made please check |
Nice |
@itsekta can you please merge the pull request |
@apu52 will be merging it |
Yes make it soon |
Title and Issue number
Title :Added social media links
Issue No. : #892
Code Stack :
Close #892
Description
I have added social media links
Video/Screenshots (mandatory)
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24
VSOC'24