Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added social media links #893

Merged
merged 4 commits into from
Jun 28, 2024
Merged

feat: Added social media links #893

merged 4 commits into from
Jun 28, 2024

Conversation

Saipradyumnagoud
Copy link
Contributor

@Saipradyumnagoud Saipradyumnagoud commented Jun 21, 2024

Title and Issue number

Title :Added social media links

Issue No. : #892

Code Stack :

Close #892

Description

I have added social media links

Video/Screenshots (mandatory)

image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • [x ] I have performed a self-review of my code.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • [ x] I have tested the changes thoroughly before submitting this pull request.
  • [ x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [x ] I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • [x ] I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit a7a6117
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/667da3c2a084ec0008dc8bbc
😎 Deploy Preview https://deploy-preview-893--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Saipradyumnagoud! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@Saipradyumnagoud Saipradyumnagoud changed the title Added social media links Feat : Added social media links Jun 21, 2024
@Saipradyumnagoud
Copy link
Contributor Author

@apu52 can you please review soon

@Saipradyumnagoud
Copy link
Contributor Author

@itsekta can you please review it 🙏🏾

@apu52 apu52 changed the title Feat : Added social media links feat: Added social media links Jun 26, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saipradyumnagoud there is some recent changes in the website page so that your PR is facing some merging conflicts . so I would like to request you to submit a new PR making a new branch in your forked PR to avoid all of the conflicts
Otherwise the features u have added are working well .I have checked it

@apu52 apu52 added the help wanted Extra attention is needed label Jun 26, 2024
@Saipradyumnagoud
Copy link
Contributor Author

@apu52 Now please go through the pull request

@itsekta
Copy link

itsekta commented Jun 27, 2024

Hey @Saipradyumnagoud, can you also improve the UI a little bit by adding gap between them, keep the icon color to white and on hovering over the icons change the color of the icons to their default icon instead of white only. Suppose Facebook icon color is blue (#1877F2) by default the icons are white only but on hovering over the facebook icon the color should be #1877F2. Similar for all the icons, checkout the colors for other icons as well

@Saipradyumnagoud
Copy link
Contributor Author

Hey @Saipradyumnagoud, can you also improve the UI a little bit by adding gap between them, keep the icon color to white and on hovering over the icons change the color of the icons to their default icon instead of white only. Suppose Facebook icon color is blue (#1877F2) by default the icons are white only but on hovering over the facebook icon the color should be #1877F2. Similar for all the icons, checkout the colors for other icons as well

Yes sure i will work on it

@Saipradyumnagoud
Copy link
Contributor Author

image

@Saipradyumnagoud
Copy link
Contributor Author

@apu52 @itsekta made the required changes requested

@itsekta
Copy link

itsekta commented Jun 27, 2024

@Saipradyumnagoud, why are the icons getting smaller on hover

@Saipradyumnagoud
Copy link
Contributor Author

@Saipradyumnagoud, why are the icons getting smaller on hover

Should i make icons bigger on hover

@itsekta
Copy link

itsekta commented Jun 27, 2024

Your choice, you can make a little bigger (scale 0.5) or don't just the ui should look nice.

@Saipradyumnagoud
Copy link
Contributor Author

@itsekta yes now i have made please check

@itsekta
Copy link

itsekta commented Jun 27, 2024

Nice

@Saipradyumnagoud
Copy link
Contributor Author

Nice

@itsekta can you please merge the pull request

@itsekta
Copy link

itsekta commented Jun 28, 2024

@apu52 will be merging it

@Saipradyumnagoud
Copy link
Contributor Author

@apu52 will be merging it

Yes make it soon

@apu52 apu52 merged commit b48381b into apu52:main Jun 28, 2024
6 checks passed
@apu52 apu52 added level2 gssoc and removed help wanted Extra attention is needed labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Adding social media links in the footer
3 participants