Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Climate visible for destinations #901

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Conversation

vidhiisaxena
Copy link
Contributor

Title and Issue number

Title : [Bug]: Climate for travel destinations is undefined

Issue No. : #895

Code Stack : JavaScript (imported axios and used apikey), HTML5

Close #895

Description

Imported Axios to get data using API key and added html tags to ensure that data is visible on website. Repeated this process for 12 cities.

Video/Screenshots (mandatory)

image

Type of PR

  • [ ✅] Bug fix
  • [X ] Feature enhancement
  • [ X] Documentation update
  • [ X] Other (specify): _______________

Checklist:

  • [✅ ] I have performed a self-review of my code.
  • [X ] I have commented my code, particularly in hard-to-understand areas.
  • [✅ ] I have tested the changes thoroughly before submitting this pull request.
  • [ ✅] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ ✅] I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • [✅ ] I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 553c9b2
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6679554c707cdc0008803e11
😎 Deploy Preview https://deploy-preview-901--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vidhiisaxena! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@vidhiisaxena vidhiisaxena changed the title [fix]: Climate visible for destinations now Fix : Climate visible for destinations now Jun 24, 2024
@vidhiisaxena vidhiisaxena changed the title Fix : Climate visible for destinations now Fix : Climate visible for destinations #895 Jun 24, 2024
@vidhiisaxena vidhiisaxena changed the title Fix : Climate visible for destinations #895 Fix : Climate visible for destinations Jun 24, 2024
@vidhiisaxena vidhiisaxena changed the title Fix : Climate visible for destinations fix : Climate visible for destinations Jun 24, 2024
@vidhiisaxena vidhiisaxena changed the title fix : Climate visible for destinations fix: Climate visible for destinations Jun 24, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vidhiisaxena good work

@apu52 apu52 merged commit ff9d723 into apu52:main Jun 26, 2024
6 of 11 checks passed
@apu52 apu52 added bug Something isn't working level2 gssoc labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Climate for travel destinations is undefined.
2 participants