Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LOGIN PAGE IS UPDATED #910

Closed
wants to merge 1 commit into from
Closed

feat: LOGIN PAGE IS UPDATED #910

wants to merge 1 commit into from

Conversation

AbheetHacker4278
Copy link
Contributor

@AbheetHacker4278 AbheetHacker4278 commented Jun 26, 2024

Title and Issue number

#900

Title :
LOGIN PAGE IMPROVEMNT

Issue No. : #900

Code Stack : HTML , CSS , JS

Description

I have Updated the Login page with cool animated Background of Nature Theme.

Video/Screenshots (mandatory)

BEFORE

Screenshot 2024-06-24 134930

AFTER

02-08-43.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

EYES APPELING

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 5d0c149
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/667c7f133ef2ce00077b5e8f
😎 Deploy Preview https://deploy-preview-910--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AbheetHacker4278! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@AbheetHacker4278 AbheetHacker4278 changed the title LOGIN PAGE IS UPDATED feat:LOGIN PAGE IS UPDATED Jun 26, 2024
@AbheetHacker4278 AbheetHacker4278 changed the title feat:LOGIN PAGE IS UPDATED feat: LOGIN PAGE IS UPDATED Jun 26, 2024
@AbheetHacker4278
Copy link
Contributor Author

@itsekta @apu52 please REVIEW THIS PR AND MERGE THIS PR WITH MAIN BRANCH.
Thank You

@AbheetHacker4278
Copy link
Contributor Author

@itsekta @apu52 have you liked the changes

@itsekta
Copy link

itsekta commented Jun 27, 2024

Hey @AbheetHacker4278, nice try with the UI for the login page! Do you have any other options? Currently, I think the previous login UI looks better. The current design lacks consistency with padding, colors, and buttons.

@AbheetHacker4278
Copy link
Contributor Author

AbheetHacker4278 commented Jun 27, 2024

Hey @AbheetHacker4278, nice try with the UI for the login page! Do you have any other options? Currently, I think the previous login UI looks better. The current design lacks consistency with padding, colors, and buttons.

Okay I Understand , thanks for Honest Review , i think trip gallery sections need some update and changes , so i can add cool animated cards , is it Okay ?

image

@itsekta

@itsekta
Copy link

itsekta commented Jun 27, 2024

Yeah, go ahead you can work on it in a separate issue, I'm closing this for now.

@itsekta itsekta closed this Jun 27, 2024
@AbheetHacker4278 AbheetHacker4278 deleted the logon branch June 27, 2024 17:52
@AbheetHacker4278 AbheetHacker4278 restored the logon branch June 27, 2024 17:54
@AbheetHacker4278 AbheetHacker4278 deleted the logon branch June 27, 2024 17:55
@AbheetHacker4278 AbheetHacker4278 restored the logon branch June 27, 2024 17:55
@AbheetHacker4278 AbheetHacker4278 deleted the logon branch June 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants