-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FAQ Page inproved #926
Conversation
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @sau-mili, have you checked the UI on the preview link above. The UI for FAQ now looks like this This can be improved with a nice UI |
The one that you shared is on the home page, and I edited the specific “Faqs” page. |
Okay got it, just checked the faq page nice work 👍 |
Improved FAQ page PR #926 |
What’s wrong then? What do i need to improve? |
Nothing is wrong, I have just closed the issues as you have already created a pull request that is #926 |
But it was not merged. That’s why asking |
These PR will be merged by Project admin only when he get the time to merge, Don't worry they will be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sau-mili although I can see your brilliant changes in the Footer FAQ page , but along side in your pR the home page FAQ is not aligned correctly (maybe the CSS file of that is not linked with the HTML file) That has already been Identified by the Mentor @itsekta .thanks @itsekta
@sau-mili please solve the problems in your PR mentioned above so that I can approve your PR
Do you mean to align the faq page and home page faq section with similar UI? |
Hey @sau-mili, the /faq pages looks perfect but the landing page faq section still need some improvement |
okay i will fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sau-mili very good work
Title and Issue number
Title :
Issue No. : #909
Code Stack : HTML, CSS, JS
Close #909
Description
Video/Screenshots (mandatory)
NOW
faq.mp4
BEFORE
Type of PR
Checklist:
contributing.md
file before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24
VSOC'24