Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: FAQ Page inproved #926

Merged
merged 7 commits into from
Jul 4, 2024
Merged

feat: FAQ Page inproved #926

merged 7 commits into from
Jul 4, 2024

Conversation

sau-mili
Copy link
Contributor

@sau-mili sau-mili commented Jun 27, 2024

Title and Issue number

Title :

Issue No. : #909

Code Stack : HTML, CSS, JS

Close #909

Description

  • Added new accordion system to the page
  • Added navabar
  • Edited minute bugs in index.html file
  • Also CSS for the FAQ page is done

Video/Screenshots (mandatory)

NOW

faq.mp4

Screenshot 2024-06-28 010907

BEFORE

Screenshot 2024-06-28 010414

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit e3c0f54
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66869166e14977000891f38f
😎 Deploy Preview https://deploy-preview-926--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sau-mili sau-mili changed the title FAQ Page inproved feat:FAQ Page inproved Jun 27, 2024
@sau-mili sau-mili changed the title feat:FAQ Page inproved feat: FAQ Page inproved Jun 27, 2024
@itsekta
Copy link

itsekta commented Jun 28, 2024

Hey @sau-mili, have you checked the UI on the preview link above. The UI for FAQ now looks like this

image

This can be improved with a nice UI

@sau-mili
Copy link
Contributor Author

The one that you shared is on the home page, and I edited the specific “Faqs” page.
Do you want me to edit the home page as well?

@itsekta
Copy link

itsekta commented Jun 28, 2024

The one that you shared is on the home page, and I edited the specific “Faqs” page. Do you want me to edit the home page as well?

Okay got it, just checked the faq page nice work 👍

@itsekta
Copy link

itsekta commented Jun 28, 2024

Improved FAQ page PR #926

@itsekta itsekta closed this Jun 28, 2024
@sau-mili
Copy link
Contributor Author

What’s wrong then? What do i need to improve?

@itsekta
Copy link

itsekta commented Jun 28, 2024

Nothing is wrong, I have just closed the issues as you have already created a pull request that is #926

@sau-mili
Copy link
Contributor Author

But it was not merged. That’s why asking

@itsekta
Copy link

itsekta commented Jun 28, 2024

These PR will be merged by Project admin only when he get the time to merge, Don't worry they will be merged

@itsekta itsekta reopened this Jul 1, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sau-mili although I can see your brilliant changes in the Footer FAQ page , but along side in your pR the home page FAQ is not aligned correctly (maybe the CSS file of that is not linked with the HTML file) That has already been Identified by the Mentor @itsekta .thanks @itsekta

@sau-mili please solve the problems in your PR mentioned above so that I can approve your PR

@apu52 apu52 added the help wanted Extra attention is needed label Jul 3, 2024
@sau-mili
Copy link
Contributor Author

sau-mili commented Jul 3, 2024

Do you mean to align the faq page and home page faq section with similar UI?

@itsekta
Copy link

itsekta commented Jul 4, 2024

Hey @sau-mili, the /faq pages looks perfect but the landing page faq section still need some improvement
Firstly it isn't collapsible like it was earlier and secondly why are we showing both the icons at same time (the arrow down and close icon), should it be something like if it is open show close icons and if it isn't open down arrow icon and vice versa.

image

@itsekta itsekta requested review from itsekta and removed request for itsekta July 4, 2024 10:03
@sau-mili
Copy link
Contributor Author

sau-mili commented Jul 4, 2024

okay i will fix it

@sau-mili
Copy link
Contributor Author

sau-mili commented Jul 4, 2024

please check now
image

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sau-mili very good work

@apu52 apu52 merged commit 01122e3 into apu52:main Jul 4, 2024
6 checks passed
@apu52 apu52 added enhancement New feature or request level2 gssoc and removed help wanted Extra attention is needed labels Jul 4, 2024
@sanjay-kv sanjay-kv removed the level2 label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Improve the FAQ page
4 participants