Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue #796 fixed Destination Section #972

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Conversation

Praneeth-2602
Copy link
Contributor

Title and Issue number

Title :

Issue No. : #796

Code Stack :
HTML
CSS

Close #796

Description

Solved the issue of dual images in the destination section

Video/Screenshots (mandatory)

tourguide.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit d3f84c8
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/668b8cbe0674b2000778d2c6
😎 Deploy Preview https://deploy-preview-972--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Praneeth-2602
Copy link
Contributor Author

@apu52 that pr had some serious merge conflicts... I tried solving them twice but couldn't. I had to fork the repo again

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Praneeth-2602
image

This image in the slider is not loading in your PR .Please look into the matter. SO that I can review the PR

@apu52 apu52 added the help wanted Extra attention is needed label Jul 3, 2024
@techy4shri
Copy link
Contributor

there is a help wanted tag here, does this mean that other contributers are allowed to help?

@apu52
Copy link
Owner

apu52 commented Jul 7, 2024

there is a help wanted tag here, does this mean that other contributers are allowed to help?

No not now....I have added this tag...for the contributor ...at first he will try to solve

@Praneeth-2602
Copy link
Contributor Author

Praneeth-2602 commented Jul 8, 2024

The issue is solved I hope :)

image

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Praneeth-2602 good work

@apu52 apu52 merged commit a971b05 into apu52:main Jul 13, 2024
6 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc and removed help wanted Extra attention is needed labels Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Destination section
3 participants