Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Now navbar id displayed on click of the hamburger on the rate us page. #980

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

meetarora10
Copy link
Contributor

Title and Issue number

Title :On click of the hamburger icon in the Rate Us page nothing happens.

Issue No. : #923

Code Stack : CSS,JavaScript

Close #923

Description

Now on click of the hamburger icon , the navbar appears properly.And also made this navbar responsive for smaller devices.

Video/Screenshots (mandatory)

Star.Rating.Mozilla.Firefox.2024-07-04.11-31-32.mp4

Type of PR

  • Bug fix
  • Feature enhancement

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

I have made this navbar on the rate us page responsive also.

##Are you contributing under any Open-source programme?
Yes GSSOC'24

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 4c72079
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/66863b1a17dec30008c5cbef
😎 Deploy Preview https://deploy-preview-980--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@apu52 apu52 changed the title Now navbar id displayed on click of the hamburger on the rate us page. fix: Now navbar id displayed on click of the hamburger on the rate us page. Jul 4, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meetarora10 good work

@apu52 apu52 merged commit 47a73d3 into apu52:main Jul 4, 2024
6 of 7 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: On click pf the hamburger icon on the Rate Us page nothing happens.
2 participants