Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Footer Section alignment issue fixed #982

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Conversation

TBorundia
Copy link
Contributor

@TBorundia TBorundia commented Jul 4, 2024

Title and Issue number

Title : Footer Section alignment
Issue No. : #906

Code Stack :

Close #906

Description

1.Alignment issue of the text and links.
2. Icons where displaying twice.
3. Google translator script working .
4. Hovering effect to icons according to there logo.
5. Made the page responsive too.

Video/Screenshots (mandatory)

Before:
Screenshot 2024-07-04 013705

After:

travelWebsite_footer.mp4

Also made is responsive for small screen:
Screenshot 2024-07-04 124440

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24
  • I am contributing under VSOC'24

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 1d11d64
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6686ed7d3eb7900008a86777
😎 Deploy Preview https://deploy-preview-982--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TBorundia
Copy link
Contributor Author

@apu52 @itsekta , please review this PR. Thank You!

@itsekta
Copy link

itsekta commented Jul 4, 2024

Hey @TBorundia, can you also look for this additional space in footer is doesn't looks nice
image

@TBorundia
Copy link
Contributor Author

@itsekta ,
which space mam?
The space , beside of 3 lines of header section?

@itsekta
Copy link

itsekta commented Jul 4, 2024

The white space

@TBorundia
Copy link
Contributor Author

The white space

Ok mam, I will also solve this issue.

@apu52 apu52 changed the title Footer Section alignment issue fixed fix: Footer Section alignment issue fixed Jul 4, 2024
@apu52
Copy link
Owner

apu52 commented Jul 4, 2024

The white space

Ok mam, I will also solve this issue.

have u done the changes which @itsekta ma'am have already mentioned?? If yes then just reply So that I can review your PR

@TBorundia
Copy link
Contributor Author

The white space

Ok mam, I will also solve this issue.

have u done the changes which @itsekta ma'am have already mentioned?? If yes then just reply So that I can review your PR

@apu52 @itsekta ,
I have made the changes and removed the white space also that mam asked for.
Please review this PR.

@apu52 apu52 removed the WAITING label Jul 5, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TBorundia good work

@apu52 apu52 merged commit e7a047d into apu52:main Jul 5, 2024
7 checks passed
@apu52 apu52 added bug Something isn't working level2 gssoc labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Footer Section alignment issue
3 participants