Added title & meta description + image for all plages #1050
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
Check the status or cancel PullRequest code review here.
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 205
- 6,130
97% Jest Snapshot (tests)
3% TSX
<1% JSON
<1% OtherGenerated lines of change
+ 29
- 28
Type of change
Deletion - These changes are mostly removing or cleaning up existing code within the repository.
There was a problem hiding this comment.
The code changes look good, but I mentioned a couple minor typos that would be nice to fix before merging.
Reviewed with ❤️ by PullRequest
| <meta property="og:image:alt" content="This image displays the | ||
| Aqualink Smart Buoy which is also known as Smart Mooring Spotter. This | ||
| Smart buoy is powered by solar panels and transmit data in real-time over | ||
| the air. It collects whind, wave, barometric pressure and temperature |
| surface temperature, and SST Anomaly. Each site has a dashboard that allows | ||
| you to monitor your reef. It includes a map, survey feature, satellite data | ||
| with wind, wave, and temperature data, heat stress alerts for coral | ||
| bleaching, and graphs. " /> |
There was a problem hiding this comment.
Thank you, Dallas!
There was a problem hiding this comment.
Thanks for fixing all the little things. I found one more and marked it in case that's helpful too.
Reviewed with ❤️ by PullRequest
| <meta property="og:image:alt" content="The images display the Aqualink | ||
| dashboard, which allows you to monitor your reef. It includes a map, | ||
| survey feature, satellite data with wind, wave, and temperature data, | ||
| heat stress alerts for coral bleaching, and graphs. " /> |
I added title, meta description, and meta image to all pages. I also added:
and
import { HelmetProvider } from 'react-helmet-async';
to packages/website/src/index.tsx
I did not add React Helmet. Please add this and the second step as @K-Markopoulos mentioned:
"As Eric mentioned, the react-helmet is not enough on its own in order to complete this task. The Helmet changes the meta tags on runtime, but the bots/crawlers that read those tags do not run the app, they just fetch the index.html. Therefore one solution is to generate an html file for each path and for each site. We have already started this, but it's a bigger effort and it has been put to the side to prioritize Reef Check data integration.
Adding Helmet is 1 of the 2 steps required here. The proposed changes look good, so feel free to add them while we are working on the other step to add Static Generation on the app."
This Pull Request is linked with Issue #641