Add pagination to table #1058
Merged
Add pagination to table #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericboucher
commented
Nov 20, 2024
| @@ -50,7 +51,31 @@ export const SiteMarkers = ({ collection }: SiteMarkersProps) => { | |||
| }, | |||
| [], | |||
| ); | |||
| // zoom in and center on site marker when it's clicked | |||
|
|
|||
| const filterSitesByViewport = useCallback(() => { | |||
There was a problem hiding this comment.
@K-Markopoulos is that useful or should we remove this for now?
There was a problem hiding this comment.
I think it's an improvement in performance, so it's worth keep it until we come up with a better solution.
|
Build succeeded and deployed at https://aqualink-app-1058.surge.sh |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
Check the status or cancel PullRequest code review here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of the reef check data that has a lot of sites, we propose to add pagination to the sites table (or virtualisation, see #1054)