Add Reef check survey page #1060
Conversation
K-Markopoulos
force-pushed
the
reef-check-survey-page
branch
from
cf1f81c
to
5781f20
Compare
|
Build succeeded and deployed at https://aqualink-app-1060.surge.sh |
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@K-Markopoulos you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
PullRequest Breakdown
Reviewable lines of change
+ 1,476
- 1
44% TSX
39% TypeScript
17% TSX (tests)
<1% JSON
<1% OtherType of change
Feature - These changes are adding a new feature or improvement to existing code.
| 1 Message | |
|---|---|
| Due to its size, this pull request will likely have a little longer turnaround time and will probably require multiple passes from our reviewers. |
There was a problem hiding this comment.
I've given this MR a quick first pass, and noticed an issue, noted inline. Second pass to follow, shortly.
Reviewed with ❤️ by PullRequest
|
|
||
| export const getReefCheckSurvey = async (siteId: string, id: string) => | ||
| requests.send<ReefCheckSurvey>({ | ||
| url: `reef-check-sites/${siteId}/surveys/${id}`, |
There was a problem hiding this comment.
Nice catch, done.
There was a problem hiding this comment.
I've completed my second pass, and noticed just one additional issue, besides the smattering of TODO comments.
Reviewed with ❤️ by PullRequest
| a 100-meter transect line for a total survey area of 400m². Each | ||
| segment has an area of 100m² and is labelled as s1, s2, s3, or s4. | ||
| </Typography> | ||
| <Link |
There was a problem hiding this comment.
It doesn't, but as I found out all major browsers imply rel='noreferrer' on target='_blank' links. I added it anyway, thanks for the suggestion.
Note: requires backend changes from #1052 to work.
Add reef check survey page in UI. Designs
Next steps for this PR:
Reconsider details layout (from flex to table)We keep the flex with media queries forcolumn-count