Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reef check surveys in Site page #1064

Open
wants to merge 4 commits into
base: reef-check-survey-page
Choose a base branch
from

Conversation

K-Markopoulos
Copy link
Collaborator

@K-Markopoulos K-Markopoulos commented Dec 3, 2024

Based on reef-check-survey-page branch. Will switch target to master once the base branch is merged.

  • Add reef check surveys to surveys list in Site's page.
  • Show both type of Surveys in the same sorted list. Each type with its own card.
  • Create table to show a sample of survey stats.
  • Add Tests

image

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

Copy link

github-actions bot commented Dec 3, 2024

Build succeeded and deployed at https://aqualink-app-1064.surge.sh
(hash 8d6cc8f deployed at 2024-12-04T16:52:54)

@K-Markopoulos K-Markopoulos marked this pull request as ready for review December 4, 2024 16:50
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@K-Markopoulos you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 401
- 52

61% TSX
24% TypeScript
15% TSX (tests)

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good and matches the description

Image of Xiaoyong W Xiaoyong W


Reviewed with ❤️ by PullRequest

@ericboucher
Copy link
Member

Nice work @K-Markopoulos
I deployed to programize so progress can be tested here - https://aqualink-app-programize.web.app/sites/5427

One thing to update is moving the survey "date line" to the left to make more room fo the table as you can see from the designs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants