Merge pull request #124 from aquariophilie/feature/validation_and_lookup

Feature/validation and lookup
aquariophilie · Nov 24, 2021 · b4350bd · b4350bd
2 parents 94bfe26 + 2a1960a
commit b4350bd
Show file tree

Hide file tree

Showing 20 changed files with 267 additions and 129 deletions.
diff --git a/.github/linters/.eslintrc.json b/.github/linters/.eslintrc.json
@@ -0,0 +1,11 @@
+{
+  "parser": "@typescript-eslint/parser",
+  "plugins": ["@typescript-eslint"],
+  "extends": [
+    "plugin:@typescript-eslint/recommended"
+  ],
+  "rules": {
+    "@typescript-eslint/no-var-requires": 0,
+    "@typescript-eslint/no-empty-interface": 0
+  }
+}
diff --git a/.github/linters/.htmlhintrc b/.github/linters/.htmlhintrc
@@ -10,7 +10,7 @@
   "spec-char-escape": true,
   "id-unique": false,
   "src-not-empty": true,
-  "title-require": false,
+  "title-require": true,
   "alt-require": true,
   "doctype-html5": true,
   "id-class-value": false,
@@ -21,5 +21,5 @@
   "id-class-ad-disabled": false,
   "href-abs-or-rel": false,
   "attr-unsafe-chars": true,
-  "head-script-disabled": false
+  "head-script-disabled": true
 }
diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml
@@ -53,3 +53,8 @@ jobs:
           VALIDATE_ALL_CODEBASE: false
           DEFAULT_BRANCH: main
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          FILTER_REGEX_EXCLUDE: .*vscode/.*.json
+          VALIDATE_JAVASCRIPT_STANDARD: false
+          TYPESCRIPT_ES_CONFIG_FILE: .eslintrc.json
+          VALIDATE_TYPESCRIPT_STANDARD: false
+          VALIDATE_MARKDOWN: false
diff --git a/client/src/app.html b/client/src/app.html
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
 <html lang="en">
   <head>
+    <title>Blobfishes app</title>
     <meta charset="utf-8" />
     <link rel="icon" href="/favicon.png" />
     <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css">

diff --git a/client/src/lib/api.author.js b/client/src/lib/api.author.js
@@ -0,0 +1,31 @@
+import axios from 'axios'
+import {
+  API_PATH
+} from './api';
+
+const apiAuthorPath = `${API_PATH}/author`;
+
+function findAuthors() {
+  return axios.get(apiAuthorPath);
+}
+
+function insertAuthor(payload) {
+  return axios.post(apiAuthorPath, payload);
+}
+
+function updateAuthor(id, payload) {
+  const path = `${apiAuthorPath}/${id}`;
+  return axios.put(path, payload);
+}
+
+function removeAuthor(id) {
+  const path = `${apiAuthorPath}/${id}`;
+  return axios.delete(path);
+}
+
+export const apiAuthor = {
+  findAuthors,
+  insertAuthor,
+  updateAuthor,
+  removeAuthor
+}
diff --git a/client/src/lib/api.book.js b/client/src/lib/api.book.js
@@ -0,0 +1,31 @@
+import axios from 'axios'
+import {
+  API_PATH
+} from './api';
+
+const apiBookPath = `${API_PATH}/book`;
+
+function findBooks() {
+  return axios.get(apiBookPath);
+}
+
+function insertBook(payload) {
+  return axios.post(apiBookPath, payload);
+}
+
+function updateBook(id, payload) {
+  const path = `${apiBookPath}/${id}`;
+  return axios.put(path, payload);
+}
+
+function removeBook(id) {
+  const path = `${apiBookPath}/${id}`;
+  return axios.delete(path);
+}
+
+export const apiBook = {
+  findBooks,
+  insertBook,
+  updateBook,
+  removeBook
+}
diff --git a/client/src/lib/api.js b/client/src/lib/api.js
@@ -0,0 +1 @@
+export const API_PATH = '/api';
diff --git a/client/src/lib/requests.js b/client/src/lib/requests.js
diff --git a/client/src/routes/authors.svelte b/client/src/routes/authors.svelte
@@ -1,5 +1,4 @@
 <script>
-  import axios from "axios";
   import { onMount } from "svelte";
   import {
     Button,
@@ -14,8 +13,7 @@
     Label,
     Table,
   } from "sveltestrap";
-
-  const apiPath = "/api/author";
+  import { apiAuthor } from "../lib/api.author";
 
   var authors = [];
   var addAuthorForm = {
@@ -28,15 +26,13 @@
   let updateopen = false;
 
   function getAuthors() {
-    axios.get(`${apiPath}`).then((res) => {
+    apiAuthor.findAuthors().then((res) => {
       authors = res.data;
     });
   }
 
   function deleteAuthor(author) {
-    const path = `${apiPath}/${author._id}`;
-    axios
-      .delete(path)
+    apiAuthor.removeAuthor(author._id)
       .then(() => {
         getAuthors();
       })
@@ -55,13 +51,11 @@
   }
 
   function addAuthor() {
-    const path = `${apiPath}`;
     const payload = {
       name: addAuthorForm.name,
       bio: addAuthorForm.bio,
     };
-    axios
-      .post(path, payload)
+    apiAuthor.insertAuthor(payload)
       .then(() => {
         getAuthors();
       })
@@ -74,13 +68,11 @@
   }
 
   function updateAuthor() {
-    const path = `${apiPath}/${addAuthorForm._id}`;
     const payload = {
       name: addAuthorForm.name,
       bio: addAuthorForm.bio,
     };
-    axios
-      .put(path, payload)
+    apiAuthor.updateAuthor(addAuthorForm._id, payload)
       .then(() => {
         getAuthors();
       })