-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: Fix build step #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #73 Replace 'npm run build' with 'rpm run build:server' Commit e0aba58 introduced a regression by replacing npm script "build" with "build:server". This is quick fix to make top level Dockerfile build again. Signed-off-by: Gianpaolo Macario <[email protected]>
gmacario
force-pushed
the
fix/dockerfile-run-build
branch
from
July 22, 2021 01:35
c9b6997
to
e59c8da
Compare
Locally testing to make sure that #73 is fixed
LGTM, merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #73
Replace 'npm run build' with 'rpm run build:server'
Commit e0aba58 introduced a regression
by replacing npm script "build" with "build:server".
This is quick fix to make top level Dockerfile build again.
Signed-off-by: Gianpaolo Macario [email protected]