Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Register rego rules on import #8204

Closed
wants to merge 2 commits into from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Jan 6, 2025

Description

Register rego rules on import

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 marked this pull request as ready for review January 8, 2025 22:10
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simar7
can you compare the startup time of Trivy (eg using -v command) to make sure it doesn't slow down Trivy?

@nikpivkin
Copy link
Contributor

A PR was recently introduced that changed the process for loading checks: instead of importing, they were loaded on demand. However, the current PR returns the same behavior. Why was this decision made?

@simar7
Copy link
Member Author

simar7 commented Jan 9, 2025

A PR was recently introduced that changed the process for loading checks: instead of importing, they were loaded on demand. However, the current PR returns the same behavior. Why was this decision made?

I forgot about my own PR 😆 - actually yes I didn't realize that LoadAndRegister() is exported so it can be called by users of this package. I'll take it offline with the team that requested this and close this PR.

@simar7 simar7 closed this Jan 9, 2025
@simar7 simar7 deleted the refactor-iac-pkg branch January 9, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants