-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for registry mirrors #8244
feat: add support for registry mirrors #8244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great 👍 Left small comments.
Co-authored-by: Teppei Fukuda <[email protected]>
Co-authored-by: Teppei Fukuda <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
@DmitriyLewen I tried to reduce duplicates in 2981a6f, but please correct me if I'm missing something. |
I always forget that i can use generics :( |
I'm not a big fan of generics as it complicates things, but we can use it in simple cases. |
Description
registry.mirrors
flag (only for config file)e.g. :
Related issues
Checklist