Skip to content

Commit

Permalink
feat: center the input text on the screen
Browse files Browse the repository at this point in the history
  • Loading branch information
@aradzie
aradzie committed Nov 22, 2024
1 parent bf8f48c commit 5e656e3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/keybr-textinput-ui/lib/TextLines.module.less
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
font-kerning: none;
font-variant: none;
line-height: 1.2;
text-align: center;
}

.line_wrap {
Expand Down

2 comments on commit 5e656e3

@codenius
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes using the typing trainer harder and a bit distracting, because of the different alignement of the first words of each line. In the end, it gives jumping to the next line a bit more of unneccessary friction. Thats in addition the friction thats already there, because it is a line break and you have to move your eyes all over the place. With the centered text the anticipated spot where to look for the next word is no longer valid, which makes the transition slower.

If would suggest to roll back this change, because the little improvement in style does not justify the sacrifices in ergonomics.
One could think about an opt-in setting to enable different kinds of text alignement, for users that wish to do so nevertheless. However using text-align: start; as default setting would be benefical for most of the users due to the stated reasons.

@aradzie
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have received a few complaints that this was not a good idea. Reverted it back.

Please sign in to comment.