Unify all wrappers on the MainVoting plugin #13
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
proposeAddMember()
on the MemberAccess is only callable on the MainVoting pluginproposeAddMember()
is approved on a separate plugin, because the approval rules are different from the rest of proposalsisMember
andisEditor()
from MemberAccess pluginMultisigSettings
no longer stores the address of the MainVoting pluginMultisigSettingsUpdated
only has one parameter nowcreateProposal()
from MemberAccess pluginProposalCreationForbiddenOnSameBlock()