Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify all wrappers on the MainVoting plugin #13

Merged
merged 14 commits into from
Jun 7, 2024
Merged

Conversation

brickpop
Copy link
Contributor

@brickpop brickpop commented Jun 7, 2024

Changes:

  • The MemberAccess plugin now acts as a pure helper of the MainVoting plugin
    • proposeAddMember() on the MemberAccess is only callable on the MainVoting plugin
  • The GovernancePluginsSeup grants an additional permission
    • The MainVoting plugin can propose on the MemberAccess plugin
    • MainVoting plugin is initialized with the address of MemberAccess plugin
  • proposeAddMember() is approved on a separate plugin, because the approval rules are different from the rest of proposals
  • Removing isMember and isEditor() from MemberAccess plugin
  • MultisigSettings no longer stores the address of the MainVoting plugin
  • MultisigSettingsUpdated only has one parameter now
  • Removing unused custom errors
  • Removing createProposal() from MemberAccess plugin
  • Added the custom error ProposalCreationForbiddenOnSameBlock()

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ brickpop
❌ Jør∂¡


Jør∂¡ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@brickpop brickpop merged commit b0557a0 into main Jun 7, 2024
4 checks passed
@brickpop brickpop deleted the f/unified-wrappers branch June 7, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants