ci: fix lint issues

aragon · Aug 21, 2024 · 154a8b7 · 154a8b7
1 parent 99f5cef
commit 154a8b7
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 26 deletions.
diff --git a/contracts/test/plugin/extensions/proposal.ts b/contracts/test/plugin/extensions/proposal.ts
@@ -1,7 +1,6 @@
 import {
   DAOMock,
   DAOMock__factory,
-  IDAO,
   IProposal__factory,
   ProposalMock,
   ProposalUpgradeableMock,
@@ -13,7 +12,6 @@ import {getInterfaceId} from '@aragon/osx-commons-sdk';
 import {IProposal__factory as IProposal_V1_0_0__factory} from '@aragon/osx-ethers-v1.0.0';
 import {loadFixture} from '@nomicfoundation/hardhat-network-helpers';
 import {expect} from 'chai';
-import {BigNumberish, BytesLike} from 'ethers';
 import {ethers} from 'hardhat';
 
 describe('Proposal', async () => {

diff --git a/contracts/test/plugin/plugin-clonable.ts b/contracts/test/plugin/plugin-clonable.ts
@@ -124,7 +124,7 @@ describe('PluginCloneable', function () {
       const {implementation} = await loadFixture(fixture);
       const iface = PluginCloneableMockBuild1__factory.createInterface();
 
-      let interfaceId = ethers.BigNumber.from(
+      const interfaceId = ethers.BigNumber.from(
         iface.getSighash('setTargetConfig')
       )
         .xor(ethers.BigNumber.from(iface.getSighash('getTargetConfig')))
@@ -147,7 +147,7 @@ describe('PluginCloneable', function () {
     it('reverts if caller does not have the permission', async () => {
       const {deployer, proxy, daoMock} = await loadFixture(fixture);
 
-      let newTarget = proxy.address;
+      const newTarget = proxy.address;
 
       await expect(proxy.setTargetConfig({target: newTarget, operation: 0}))
         .to.be.revertedWithCustomError(proxy, 'DaoUnauthorized')
@@ -165,10 +165,10 @@ describe('PluginCloneable', function () {
       // Set the `hasPermission` mock function to return `true`.
       await daoMock.setHasPermissionReturnValueMock(true); // answer true for all permission requests
 
-      let newTarget = proxy.address;
+      const newTarget = proxy.address;
 
-      let targetConfig = {target: newTarget, operation: 0};
-      let previousTargetConfig = {
+      const targetConfig = {target: newTarget, operation: 0};
+      const previousTargetConfig = {
         target: ethers.constants.AddressZero,
         operation: 0,
       };
@@ -205,14 +205,15 @@ describe('PluginCloneable', function () {
       const executorFactory = new CustomExecutorMock__factory(deployer);
       executor = await executorFactory.deploy();
 
-      var abiA = CustomExecutorMock__factory.abi;
-      var abiB = PluginCloneableMockBuild1__factory.abi;
+      const abiA = CustomExecutorMock__factory.abi;
+      const abiB = PluginCloneableMockBuild1__factory.abi;
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       mergedABI = abiA.concat(abiB);
     });
 
     beforeEach(async () => {
-      let data = await fixture();
+      const data = await fixture();
       const [deployer] = await ethers.getSigners();
 
       proxy = new ethers.Contract(

diff --git a/contracts/test/plugin/plugin-uups-upgradeable.ts b/contracts/test/plugin/plugin-uups-upgradeable.ts
@@ -137,7 +137,7 @@ describe('PluginUUPSUpgradeable', function () {
       const {implementation} = await loadFixture(fixture);
       const iface = PluginUUPSUpgradeableMockBuild1__factory.createInterface();
 
-      let interfaceId = ethers.BigNumber.from(
+      const interfaceId = ethers.BigNumber.from(
         iface.getSighash('setTargetConfig')
       )
         .xor(ethers.BigNumber.from(iface.getSighash('getTargetConfig')))
@@ -160,7 +160,7 @@ describe('PluginUUPSUpgradeable', function () {
     it('reverts if caller does not have the permission', async () => {
       const {deployer, proxy, daoMock} = await loadFixture(fixture);
 
-      let newTarget = proxy.address;
+      const newTarget = proxy.address;
 
       await expect(proxy.setTargetConfig({target: newTarget, operation: 0}))
         .to.be.revertedWithCustomError(proxy, 'DaoUnauthorized')
@@ -178,10 +178,10 @@ describe('PluginUUPSUpgradeable', function () {
       // Set the `hasPermission` mock function to return `true`.
       await daoMock.setHasPermissionReturnValueMock(true); // answer true for all permission requests
 
-      let newTarget = proxy.address;
+      const newTarget = proxy.address;
 
-      let targetConfig = {target: newTarget, operation: 0};
-      let previousTargetConfig = {
+      const targetConfig = {target: newTarget, operation: 0};
+      const previousTargetConfig = {
         target: ethers.constants.AddressZero,
         operation: 0,
       };
@@ -218,14 +218,15 @@ describe('PluginUUPSUpgradeable', function () {
       const executorFactory = new CustomExecutorMock__factory(deployer);
       executor = await executorFactory.deploy();
 
-      var abiA = CustomExecutorMock__factory.abi;
-      var abiB = PluginUUPSUpgradeableMockBuild1__factory.abi;
+      const abiA = CustomExecutorMock__factory.abi;
+      const abiB = PluginUUPSUpgradeableMockBuild1__factory.abi;
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       mergedABI = abiA.concat(abiB);
     });
 
     beforeEach(async () => {
-      let data = await fixture();
+      const data = await fixture();
       const [deployer] = await ethers.getSigners();
 
       proxy = new ethers.Contract(

diff --git a/contracts/test/plugin/plugin.ts b/contracts/test/plugin/plugin.ts
@@ -67,7 +67,7 @@ describe('Plugin', function () {
       const {plugin} = await loadFixture(fixture);
       const iface = PluginMockBuild1__factory.createInterface();
 
-      let interfaceId = ethers.BigNumber.from(
+      const interfaceId = ethers.BigNumber.from(
         iface.getSighash('setTargetConfig')
       )
         .xor(ethers.BigNumber.from(iface.getSighash('getTargetConfig')))
@@ -90,7 +90,7 @@ describe('Plugin', function () {
     it('reverts if caller does not have the permission', async () => {
       const {deployer, plugin, daoMock} = await loadFixture(fixture);
 
-      let newTarget = plugin.address;
+      const newTarget = plugin.address;
 
       await expect(plugin.setTargetConfig({target: newTarget, operation: 0}))
         .to.be.revertedWithCustomError(plugin, 'DaoUnauthorized')
@@ -105,13 +105,13 @@ describe('Plugin', function () {
     it('updates the target and emits an appropriate event', async () => {
       const {plugin, daoMock} = await loadFixture(fixture);
 
-      let newTarget = plugin.address;
+      const newTarget = plugin.address;
 
       // Set the `hasPermission` mock function to return `true`.
       await daoMock.setHasPermissionReturnValueMock(true); // answer true for all permission requests
 
-      let targetConfig = {target: newTarget, operation: 0};
-      let previousTargetConfig = {
+      const targetConfig = {target: newTarget, operation: 0};
+      const previousTargetConfig = {
         target: ethers.constants.AddressZero,
         operation: 0,
       };
@@ -148,14 +148,15 @@ describe('Plugin', function () {
       const executorFactory = new CustomExecutorMock__factory(deployer);
       executor = await executorFactory.deploy();
 
-      var abiA = CustomExecutorMock__factory.abi;
-      var abiB = PluginMockBuild1__factory.abi;
+      const abiA = CustomExecutorMock__factory.abi;
+      const abiB = PluginMockBuild1__factory.abi;
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore
       mergedABI = abiA.concat(abiB);
     });
 
     beforeEach(async () => {
-      let data = await fixture();
+      const data = await fixture();
       const [deployer] = await ethers.getSigners();
 
       plugin = new ethers.Contract(