add get proposalid in the interface

aragon · Aug 27, 2024 · 5306a73 · 5306a73
1 parent f4dc570
commit 5306a73
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/contracts/src/plugin/extensions/proposal/IProposal.sol b/contracts/src/plugin/extensions/proposal/IProposal.sol
@@ -49,6 +49,15 @@ interface IProposal {
     /// @return bool Returns if proposal can be executed or not.
     function canExecute(uint256 proposalId) external returns (bool);
 
+    /// @notice Creates a proposal Id.
+    /// @param actions The actions that will be executed after the proposal passes.
+    /// @param metadata The custom metadata that is passed when creating a proposal.
+    /// @return proposalId The id of the proposal.
+    function getProposalId(
+        IDAO.Action[] memory actions,
+        bytes memory metadata
+    ) external returns (uint256);
+
     /// @notice Returns the proposal count determining the next proposal ID.
     /// @dev This function has been deprecated but due to backwards compatibility, it still stays in the interface
     /// but returns maximum value of uint256 to let consumers know not to depend on it anymore.

diff --git a/contracts/src/plugin/extensions/proposal/Proposal.sol b/contracts/src/plugin/extensions/proposal/Proposal.sol
@@ -26,7 +26,8 @@ abstract contract Proposal is IProposal, ERC165 {
             _interfaceId ==
             type(IProposal).interfaceId ^
                 IProposal.createProposal.selector ^
-                IProposal.canExecute.selector ||
+                IProposal.canExecute.selector ^
+                IProposal.getProposalId.selector ||
             _interfaceId == type(IProposal).interfaceId ||
             super.supportsInterface(_interfaceId);
     }

diff --git a/contracts/src/plugin/extensions/proposal/ProposalUpgradeable.sol b/contracts/src/plugin/extensions/proposal/ProposalUpgradeable.sol
@@ -32,7 +32,8 @@ abstract contract ProposalUpgradeable is IProposal, ERC165Upgradeable {
             _interfaceId ==
             type(IProposal).interfaceId ^
                 IProposal.createProposal.selector ^
-                IProposal.canExecute.selector ||
+                IProposal.canExecute.selector ^
+                IProposal.getProposalId.selector ||
             _interfaceId == type(IProposal).interfaceId ||
             super.supportsInterface(_interfaceId);
     }