fix calldata to memory

aragon · Aug 14, 2024 · b233838 · b233838
1 parent f6f5f3d
commit b233838
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/contracts/src/plugin/Plugin.sol b/contracts/src/plugin/Plugin.sol
@@ -55,7 +55,7 @@ abstract contract Plugin is IPlugin, ERC165, DaoAuthorizable, ProtocolVersion {
     /// @return failureMap address of the implementation contract.
     function _execute(
         bytes32 _callId,
-        IDAO.Action[] calldata _actions,
+        IDAO.Action[] memory _actions,
         uint256 _allowFailureMap
     ) internal virtual returns (bytes[] memory execResults, uint256 failureMap) {
         (execResults, failureMap) = IDAO(target).execute(_callId, _actions, _allowFailureMap);
@@ -71,7 +71,7 @@ abstract contract Plugin is IPlugin, ERC165, DaoAuthorizable, ProtocolVersion {
     function _execute(
         address _target,
         bytes32 _callId,
-        IDAO.Action[] calldata _actions,
+        IDAO.Action[] memory _actions,
         uint256 _allowFailureMap
     ) internal virtual returns (bytes[] memory execResults, uint256 failureMap) {
         (execResults, failureMap) = IDAO(_target).execute(_callId, _actions, _allowFailureMap);

diff --git a/contracts/src/plugin/PluginCloneable.sol b/contracts/src/plugin/PluginCloneable.sol
@@ -69,7 +69,7 @@ abstract contract PluginCloneable is
     /// @return failureMap address of the implementation contract.
     function _execute(
         bytes32 _callId,
-        IDAO.Action[] calldata _actions,
+        IDAO.Action[] memory _actions,
         uint256 _allowFailureMap
     ) internal virtual returns (bytes[] memory execResults, uint256 failureMap) {
         (execResults, failureMap) = IDAO(target).execute(_callId, _actions, _allowFailureMap);
@@ -85,7 +85,7 @@ abstract contract PluginCloneable is
     function _execute(
         address _target,
         bytes32 _callId,
-        IDAO.Action[] calldata _actions,
+        IDAO.Action[] memory _actions,
         uint256 _allowFailureMap
     ) internal virtual returns (bytes[] memory execResults, uint256 failureMap) {
         (execResults, failureMap) = IDAO(_target).execute(_callId, _actions, _allowFailureMap);

diff --git a/contracts/src/plugin/PluginUUPSUpgradeable.sol b/contracts/src/plugin/PluginUUPSUpgradeable.sol
@@ -83,7 +83,7 @@ abstract contract PluginUUPSUpgradeable is
     /// @return failureMap address of the implementation contract.
     function _execute(
         bytes32 _callId,
-        IDAO.Action[] calldata _actions,
+        IDAO.Action[] memory _actions,
         uint256 _allowFailureMap
     ) internal virtual returns (bytes[] memory execResults, uint256 failureMap) {
         (execResults, failureMap) = IDAO(target).execute(_callId, _actions, _allowFailureMap);
@@ -99,7 +99,7 @@ abstract contract PluginUUPSUpgradeable is
     function _execute(
         address _target,
         bytes32 _callId,
-        IDAO.Action[] calldata _actions,
+        IDAO.Action[] memory _actions,
         uint256 _allowFailureMap
     ) internal virtual returns (bytes[] memory execResults, uint256 failureMap) {
         (execResults, failureMap) = IDAO(_target).execute(_callId, _actions, _allowFailureMap);

diff --git a/contracts/src/plugin/extensions/proposal/Proposal.sol b/contracts/src/plugin/extensions/proposal/Proposal.sol
@@ -22,7 +22,7 @@ abstract contract Proposal is IProposal, ERC165 {
     // this will not return the correct value anyways anymore.
     /// @inheritdoc IProposal
     function proposalCount() public view override returns (uint256) {
-        return proposalCounter.current();
+        return 0;
     }
 
     /// @notice Checks if this or the parent contract supports an interface by its ID.